add proper docs for negative prompts

sayakpaul · sayakpaul · commit 4674e7362d54 · 2025-01-11T09:33:51.000+05:30
diff --git a/src/diffusers/pipelines/flux/pipeline_flux.py b/src/diffusers/pipelines/flux/pipeline_flux.py
@@ -790,6 +790,9 @@ def __call__(
         lora_scale = (
             self.joint_attention_kwargs.get("scale", None) if self.joint_attention_kwargs is not None else None
         )
+        # should this not be like the following?
+        # has_neg_prompt = negative_prompt is not None or (negative_prompt_embeds is not None and negative_pooled_prompt_embeds is not None)
+        # do_true_cfg = true_cfg_scale > 1 and has_neg_prompt
         do_true_cfg = true_cfg_scale > 1 and negative_prompt is not None
         (
             prompt_embeds,

Original file line number	Diff line number	Diff line change
`@@ -790,6 +790,9 @@ def __call__(`
`790`	`790`	`lora_scale = (`
`791`	`791`	`self.joint_attention_kwargs.get("scale", None) if self.joint_attention_kwargs is not None else None`
`792`	`792`	`)`
	`793`	`+ # should this not be like the following?`
	`794`	`+ # has_neg_prompt = negative_prompt is not None or (negative_prompt_embeds is not None and negative_pooled_prompt_embeds is not None)`
	`795`	`+ # do_true_cfg = true_cfg_scale > 1 and has_neg_prompt`
`793`	`796`	`do_true_cfg = true_cfg_scale > 1 and negative_prompt is not None`
`794`	`797`	`(`
`795`	`798`	`prompt_embeds,`