You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# 1. move the modular_repo arg and the logic to fetch info from repo out of __init__ so that __init__ alwasy create an default modular_model_index config
1646
-
# 2. look into the serialization of modular_model_index.json, make sure the items are properly ordered like model_index.json (currently a mess)
1647
-
# 3. do we need ConfigSpec? seems pretty unnecessrary for loader, can just add and kwargs to the loader
1645
+
# 1. look into the serialization of modular_model_index.json, make sure the items are properly ordered like model_index.json (currently a mess)
1646
+
# 2. do we need ConfigSpec? the are basically just key/val kwargs
1648
1647
# 4. add validator for methods where we accpet kwargs to be passed to from_pretrained()
0 commit comments