pytest.xfail -> ValueError.

hameerabbasi · hameerabbasi · commit a20d03d96f1c · 2025-04-08T11:36:16.000+02:00
diff --git a/tests/lora/utils.py b/tests/lora/utils.py
@@ -1603,9 +1603,10 @@ def test_lora_fuse_nan(self):
                         tower_name for tower_name in possible_tower_names if hasattr(pipe.transformer, tower_name)
                     ]
                     if len(filtered_tower_names) == 0:
-                        pytest.xfail(
-                            reason=f"`pipe.transformer` didn't have any of the following attributes: {possible_tower_names}."
+                        reason = (
+                            f"`pipe.transformer` didn't have any of the following attributes: {possible_tower_names}."
                         )
+                        raise ValueError(reason)
                     for tower_name in filtered_tower_names:
                         transformer_tower = getattr(pipe.transformer, tower_name)
                         has_attn1 = any("attn1" in name for name in named_modules)

Original file line number	Diff line number	Diff line change
`@@ -1603,9 +1603,10 @@ def test_lora_fuse_nan(self):`
`1603`	`1603`	`tower_name for tower_name in possible_tower_names if hasattr(pipe.transformer, tower_name)`
`1604`	`1604`	`]`
`1605`	`1605`	`if len(filtered_tower_names) == 0:`
`1606`		`- pytest.xfail(`
`1607`		- reason=f"`pipe.transformer` didn't have any of the following attributes: {possible_tower_names}."
	`1606`	`+ reason = (`
	`1607`	+ f"`pipe.transformer` didn't have any of the following attributes: {possible_tower_names}."
`1608`	`1608`	`)`
	`1609`	`+ raise ValueError(reason)`
`1609`	`1610`	`for tower_name in filtered_tower_names:`
`1610`	`1611`	`transformer_tower = getattr(pipe.transformer, tower_name)`
`1611`	`1612`	`has_attn1 = any("attn1" in name for name in named_modules)`