Skip to content

Commit eb94150

Browse files
committed
add a to-do for modular loader
1 parent de6ab6b commit eb94150

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/diffusers/modular_pipelines/modular_pipeline.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1638,9 +1638,10 @@ def __repr__(self):
16381638

16391639

16401640
# YiYi TODO:
1641-
# 1. look into the serialization of modular_model_index.json, make sure the items are properly ordered like model_index.json (currently a mess)
1642-
# 2. do we need ConfigSpec? seems pretty unnecessrary for loader, can just add and kwargs to the loader
1643-
# 3. add validator for methods where we accpet kwargs to be passed to from_pretrained()
1641+
# 1. move the modular_repo arg and the logic to fetch info from repo out of __init__ so that __init__ alwasy create an default modular_model_index config
1642+
# 2. look into the serialization of modular_model_index.json, make sure the items are properly ordered like model_index.json (currently a mess)
1643+
# 3. do we need ConfigSpec? seems pretty unnecessrary for loader, can just add and kwargs to the loader
1644+
# 4. add validator for methods where we accpet kwargs to be passed to from_pretrained()
16441645
class ModularLoader(ConfigMixin, PushToHubMixin):
16451646
"""
16461647
Base class for all Modular pipelines loaders.

0 commit comments

Comments
 (0)