fix FluxReduxSlowTests::test_flux_redux_inference case failure on XPU #11245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass UT Signed-off-by: Matrix Yao <[email protected]>
Signed-off-by: Matrix Yao <[email protected]>
Contributor
Author
|
@hlky, pls help review, thx. |
hlky
approved these changes
Apr 9, 2025
Contributor
There was a problem hiding this comment.
Thanks @yao-matrix. Left a comment but good to go after CI is finished.
| class FluxReduxSlowTests(unittest.TestCase): | ||
| pipeline_class = FluxPriorReduxPipeline | ||
| repo_id = "YiYiXu/yiyi-redux" # update to "black-forest-labs/FLUX.1-Redux-dev" once PR is merged | ||
| repo_id = "black-forest-labs/FLUX.1-Redux-dev" |
Contributor
There was a problem hiding this comment.
Nice, thanks for updating this.
| @unittest.skipIf(torch_device not in ["cuda", "xpu"], reason="float16 requires CUDA or XPU") | ||
| @require_accelerator | ||
| def test_float16_inference(self, expected_max_diff=5e-2): | ||
| def test_float16_inference(self, expected_max_diff=6e-2): |
Contributor
There was a problem hiding this comment.
6e-2 vs 5e-2 is ok, what's the context of this change though?
Contributor
Author
There was a problem hiding this comment.
sorry, it's an un-deleted experimental change, will change back in next PR. Sorry for unnecessary confusion
Contributor
|
Failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest -rA tests/pipelines/flux/test_pipeline_flux_redux.py::FluxReduxSlowTests::test_flux_redux_inferencefail on XPU.After comparing the output btw XPU and A100, we can confirm the image is similar perceptually.
XPU:
A100:
So, I changed the XPU expectation to make it pass.
I also update the model per legacy comments.
test status:
A100: before this PR pass, after this PR pass
XPU: before this PR fail, after this PR pass