Skip to content

Fix vae.Decoder prev_output_channel #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix vae.Decoder prev_output_channel #11280

merged 1 commit into from
Apr 15, 2025

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Apr 10, 2025

What does this PR do?

Reproduction

from diffusers.models.autoencoders.vae import Decoder

decoder = Decoder(
    up_block_types=["ResnetUpsampleBlock2D"],
)

Fixes #11275

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky hlky requested review from a-r-r-o-w and sayakpaul April 10, 2025 09:08
@hlky hlky mentioned this pull request Apr 10, 2025
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul
sayakpaul approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merge blocking but would be nice to have a test

@hlky hlky merged commit 6e80d24 into huggingface:main Apr 15, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

+1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError in VAE with ResnetUpsampleBlock2D: NoneType used in addition

4 participants

@hlky @HuggingFaceDocBuilderDev @sayakpaul @a-r-r-o-w