Skip to content

Hidream refactoring follow ups #11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Apr 13, 2025
Merged

Hidream refactoring follow ups #11299

merged 29 commits into from
Apr 13, 2025

Conversation

@a-r-r-o-w
Copy link
Contributor

No description provided.

hlky and others added 26 commits April 8, 2025 13:23
@hlky
HiDream Image
642203e
@hlky
update
3b5e03b
@hlky
-einops
a40c95f
@hlky
Merge branch 'main' into hidream
eb798ed
@hlky
py3.8
a90372e
@hlky
Merge branch 'hidream' of https://github.com/hlky/diffusers into hidream
f94d68e
@hlky
fix -einops
b8aa38d
@hlky
mixins, offload_seq, option_components
9d43a32
@hlky
docs
e1766a1
@github-actions
Apply style fixes
8fbc630
@hlky
trigger tests
b6b9b45
@hlky @a-r-r-o-w
Apply suggestions from code review
8dd065b 
Co-authored-by: Aryan <[email protected]>
@hlky
joint_attention_kwargs -> attention_kwargs, fixes
8b2670d
@hlky
fast tests
f2aa727
@hlky
-_init_weights
8e328f3
@hlky
style tests
7c4eced
@hlky
move reshape logic
07c670e
@hlky
update slice 😴
efc44ea
@hlky
supports_dduf
745bcec
@hlky
🤷🏻‍♂️
c1abec6
@hlky @a-r-r-o-w
Update src/diffusers/models/transformers/transformer_hidream_image.py
9eb0b8b 
Co-authored-by: Aryan <[email protected]>
@a-r-r-o-w
address review comments
32af5ce
@a-r-r-o-w
update tests
3ec1896
@a-r-r-o-w
doc updates
2d65aa2
@a-r-r-o-w
Merge branch 'main' into hidream
72c9667
@a-r-r-o-w
update
5e0bca0
@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu April 12, 2025 05:25
a-r-r-o-w
a-r-r-o-w commented Apr 12, 2025
View reviewed changes
src/diffusers/models/transformers/transformer_hidream_image.py
self.caption_projection = nn.ModuleList(caption_projection)
self.max_seq = max_resolution[0] * max_resolution[1] // (patch_size * patch_size)

def expand_timesteps(self, timesteps, batch_size, device):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed because:

  • we already pass tensors from the pipeline
  • we already expand the shape based on batch_size in MPS friendly manner
  • we already pass torch.int64 timesteps

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

yiyixuxu
yiyixuxu approved these changes Apr 12, 2025
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu
Copy link
Collaborator

@bot /style

@github-actions
Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@a-r-r-o-w a-r-r-o-w merged commit 97e0ef4 into main Apr 13, 2025
2 checks passed
@a-r-r-o-w a-r-r-o-w deleted the refactor/hidream branch April 13, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@a-r-r-o-w @HuggingFaceDocBuilderDev @yiyixuxu @hlky