Skip to content

Conversation

@yao-matrix
Copy link
Contributor

all 46 test_layerwise_casting_memory cases pased on XPU

@yao-matrix
Copy link
Contributor Author

yao-matrix commented Apr 24, 2025

@a-r-r-o-w @DN6 , @yiyixuxu pls help review, thx.

Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the changes LGTM! With the current changes, it implies that it is expected to pass on any torch accelerator. Can you add a note to the class saying all tests are intended to pass on CUDA, but may fail on other devices?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Signed-off-by: Yao Matrix <[email protected]>
@yao-matrix
Copy link
Contributor Author

Thank you, the changes LGTM! With the current changes, it implies that it is expected to pass on any torch accelerator. Can you add a note to the class saying all tests are intended to pass on CUDA, but may fail on other devices?

Glad to do so. Yet, could you help point me the place where you think is appropriate to add this note? Thx, I'm kind of not certain the right place to do this.

@a-r-r-o-w a-r-r-o-w merged commit a7e9f85 into huggingface:main Apr 28, 2025
28 of 29 checks passed
@yao-matrix yao-matrix deleted the layerwise-xpu branch April 28, 2025 03:05
@yao-matrix yao-matrix mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants