[test_models_transformer_ltx.py] help us test torch.compile() for impactful models #11512
Conversation
| @require_torch_gpu | ||
| @require_torch_2 | ||
| @is_torch_compile | ||
| @slow | ||
| def test_torch_compile_recompilation_and_graph_break(self): | ||
| torch._dynamo.reset() | ||
| init_dict, inputs_dict = self.prepare_init_args_and_inputs_for_common() | ||
|
|
||
| model = self.model_class(**init_dict).to(torch_device) | ||
| model.eval() | ||
| model = torch.compile(model, fullgraph=True) | ||
|
|
||
| with torch._dynamo.config.patch(error_on_recompile=True), torch.no_grad(): | ||
| _ = model(**inputs_dict) | ||
| _ = model(**inputs_dict) |
There was a problem hiding this comment.
We just need to add: TorchCompileTesterMixin like this:
There was a problem hiding this comment.
@sayakpaul Thanks for the suggestion! I've added TorchCompileTesterMixin and confirmed that the test runs successfully(pytest).
There was a problem hiding this comment.
Thanks. How did you run the tests?
There was a problem hiding this comment.
I ran the tests using:
os.environ["RUN_COMPILE"] = "1"
os.environ["RUN_SLOW"] = "1"
!pytest tests/models/transformers/test_models_transformer_ltx.py -k "test_torch_compile_recompilation_and_graph_break"
Let me know if there's anything else I should verify.
There was a problem hiding this comment.
We're already including TorchCompileTesterMixin to the tester class. We can completely remove test_torch_compile_recompilation_and_graph_break().
There was a problem hiding this comment.
You're right — since TorchCompileTesterMixin already covers the necessary torch.compile checks, I've removed the redundant test_torch_compile_recompilation_and_graph_break() method.
|
Just ran the tests myself and they're passing. Thanks! Also, cc: @a-r-r-o-w for awareness on LTX. |
|
Hi @sayakpaul @a-r-r-o-w, |
|
Failing test is unrelated. |
3 participants
What does this PR do?
Part of #11430
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.