- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
          Add --lora_alpha and metadata handling for train_dreambooth_lora_hidream
          #11765
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
            ParagEkbote
  wants to merge
  20
  commits into
  huggingface:main
from
ParagEkbote:Add-Lora-Alpha-For-HiDream-Lora
  
      
      
   
      
    
                
     Closed
            
            
  
    Add --lora_alpha and metadata handling for train_dreambooth_lora_hidream
  
  #11765
              
                    ParagEkbote
  wants to merge
  20
  commits into
  huggingface:main
from
ParagEkbote:Add-Lora-Alpha-For-HiDream-Lora
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. | 
…ParagEkbote/diffusers into Add-Lora-Alpha-For-HiDream-Lora
| @bot /style | 
…ParagEkbote/diffusers into Add-Lora-Alpha-For-HiDream-Lora
| @linoytsaban I have added the missing params to fix the single failing test. Could you please review? | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What does this PR do?
Refs #11730
As described in the issue, I've updated the test and training scripts to making LoRA alpha also configurable and include the metadata handling as well. Could you please review the changes?
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@linoytsaban