Remove device synchronization when loading weights #11927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
approved these changes
Jul 15, 2025
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 17, 2025
* update * make style
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 18, 2025
* update * make style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: https://huggingface.slack.com/archives/C03UQJENJTV/p1752491900178599
When this change was added, I was under the impression that the synchronization must be used when using non_blocking data transfer. This is true if the non_blocking device transfer was async in respect to other cuda ops (i.e. if we were using a non-default stream for data transfer). It is not the case here, so it seems like we don't need a sync.