[refactor] Make guiders return their inputs #12213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
reviewed
Aug 22, 2025
| pred = rescale_noise_cfg(pred, pred_cond, self.guidance_rescale) | ||
|
|
||
| return pred, {} | ||
| return pred, guider_inputs |
Collaborator
There was a problem hiding this comment.
I would just define a GuiderOutput
and do
return GuiderOutput(pred=pred, pred_cond=pred_cond)and in the denoiser step, we can do this for now since we don't need other variables for SDXL/wan/flux
block_state.noise_pred = components.guider(guider_state)[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.