- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.5k
[Fix] chroma docs #12360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] chroma docs #12360
Conversation
| I guess it might not be the best to only remove the mentions of guidance distillation, right? The reason why I did not open the PR myself was because I am unsure what to replace the description with. Maybe copying the description from the SDXL pipeline  I am also wondering if it will be good to add further clarification about Chroma being dedistilled to use true CFG, but I guess that will make the docs too verbose? | 
| @mingyi456 . Now docs are consistent . Mentioning true_cfg will break the consistency among pipelines | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying!
| Custom sigmas to use for the denoising process with schedulers which support a `sigmas` argument in | ||
| their `set_timesteps` method. If not defined, the default behavior when `num_inference_steps` is passed | ||
| will be used. | ||
| guidance_scale (`float`, *optional*, defaults to 3.5): | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be 5.0 (same for the im2img pipeline)?
| guidance_scale: float = 5.0, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, where is the source that says chroma's default cfg should be 5.0? The comfyui recommended workflow seems to say it should be 4.0, meanwhile I had always thought that 3.5 was the correct default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @Ednaordinary who would know better since they implemented the pipeline :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both lodestones/Chroma1-Base and lodestones/Chroma1-HD have 3.0 in their readme example, though anywhere between 3 and 4 should be fine! thanks for the ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then cfg 3.5 is fine . Thanks @Ednaordinary and @mingyi456
| The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. | 
What does this PR do?
Fixes #12359 Fixes Chroma Docs
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
@stevhliu @sayakpaul