Skip to content

Conversation

@SahilCarterr
Copy link
Contributor

What does this PR do?

Fixes #12359 Fixes Chroma Docs

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed.
@stevhliu @sayakpaul

@mingyi456
Copy link
Contributor

I guess it might not be the best to only remove the mentions of guidance distillation, right? The reason why I did not open the PR myself was because I am unsure what to replace the description with. Maybe copying the description from the SDXL pipeline guidance_scale parameter might be more appropriate?

I am also wondering if it will be good to add further clarification about Chroma being dedistilled to use true CFG, but I guess that will make the docs too verbose?

fixed docs are now consistent
@SahilCarterr
Copy link
Contributor Author

@mingyi456 . Now docs are consistent . Mentioning true_cfg will break the consistency among pipelines

@sayakpaul sayakpaul requested a review from stevhliu September 21, 2025 15:28
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

Custom sigmas to use for the denoising process with schedulers which support a `sigmas` argument in
their `set_timesteps` method. If not defined, the default behavior when `num_inference_steps` is passed
will be used.
guidance_scale (`float`, *optional*, defaults to 3.5):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 5.0 (same for the im2img pipeline)?

guidance_scale: float = 5.0,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, where is the source that says chroma's default cfg should be 5.0? The comfyui recommended workflow seems to say it should be 4.0, meanwhile I had always thought that 3.5 was the correct default value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @Ednaordinary who would know better since they implemented the pipeline :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both lodestones/Chroma1-Base and lodestones/Chroma1-HD have 3.0 in their readme example, though anywhere between 3 and 4 should be fine! thanks for the ping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then cfg 3.5 is fine . Thanks @Ednaordinary and @mingyi456

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 1448b03 into huggingface:main Sep 22, 2025
10 checks passed
@SahilCarterr SahilCarterr deleted the chroma_docs branch September 22, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chroma pipeline documentation bug regarding the guidance_scale parameter

5 participants