Use of requests call without `timeout` parameter

[Sai-Suraj-27]

Describe the bug

At few places in the codebase, where requests.get() is used, the timeout parameter is not specified.

diffusers/src/diffusers/utils/loading_utils.py

Line 28 in d1e3f48

image = PIL.Image.open(requests.get(image, stream=True).raw)

The timeout parameter is used to set the maximum time to wait for a response from the server. By omitting the timeout parameter, the program may hang indefinitely while awaiting a response.

From the documentation, we can see that the value of timeout can be mentioned in seconds (like 5 seconds).

I think it's good to use the timeout parameter with a value of 5 or 10 seconds.

Reproduction

diffusers/src/diffusers/utils/loading_utils.py

Line 28 in d1e3f48

image = PIL.Image.open(requests.get(image, stream=True).raw)

diffusers/scripts/convert_vae_pt_to_diffusers.py

Lines 124 to 125 in d1e3f48

	r = requests.get(
	" https://raw.githubusercontent.com/CompVis/stable-diffusion/main/configs/stable-diffusion/v1-inference.yaml"

Logs

No response

System Info

This is a potential bug in the codebase, Irrespective of the python version, Diffusers version and platform.

Who can help?

@sayakpaul

[sayakpaul]

@DN6 what do you think?

[DN6]

Yeah timeout is a good addition. @Sai-Suraj-27 Would you like to open a PR for this?

[Sai-Suraj-27]

Yeah timeout is a good addition. @Sai-Suraj-27 Would you like to open a PR for this?

Thanks for looking into it 👍🏻. Yes, I will open a PR fixing this.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

[frankjoshua]

I was testing our error handling today. Yes a timeout would be great. v0.32.2

[asomoza]

the PR related to this issue got staled and never heard back from the author, if anyone from the community wants to take it and finish it, we would appreciate it a lot, just remember to also credit the original author of the PR.