Skip to content

[chore] remove prints from tests. #10505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

[chore] remove prints from tests. #10505

merged 1 commit into from
Jan 9, 2025
+16 −40

Conversation

@sayakpaul
Copy link
Member

No description provided.

@sayakpaul sayakpaul requested a review from hlky January 9, 2025 05:23
hlky
hlky approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can we add a message to the asserts like f"output is different from expected, {image_slice.flatten()}" in a follow-up?

@sayakpaul
Copy link
Member Author

Sure.

@sayakpaul sayakpaul merged commit daf9d0f into main Jan 9, 2025
20 checks passed
@sayakpaul sayakpaul deleted the remove-prints branch January 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hlky hlky hlky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakpaul @hlky