Fix incorrect tile_latent_min_width calculation in AutoencoderKLMochi #11294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for the review! Let me know if there's anything else needed from my side 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an inconsistency in the calculation of
tile_latent_min_widthinside the AutoencoderKLMochi decoder.Previously,
tile_latent_min_widthwas incorrectly calculated usingself.tile_sample_stride_width:This led to a mismatch with the corresponding height calculation, which correctly used
self.tile_sample_min_height. The corrected line now usesself.tile_sample_min_width.This discrepancy did not raise errors under default settings (e.g., 848x480 resolution), but could cause incorrect conditional evaluations in edge cases, such as when profiling or testing different resolutions.
Fixes #11291.
Who can review?
@a-r-r-o-w