Skip to content

tests + minor refactor for QwenImage #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2025
Merged

tests + minor refactor for QwenImage #12057

merged 4 commits into from
Aug 4, 2025

Conversation

@a-r-r-o-w
Copy link
Contributor

cc @naykun

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu August 4, 2025 04:39
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

yiyixuxu
yiyixuxu approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @a-r-r-o-w

src/diffusers/models/transformers/transformer_qwenimage.py
joint_attention_dim: int = 3584,
pooled_projection_dim: int = 768,
guidance_embeds: bool = False,
guidance_embeds: bool = False, # TODO: this should probably be removed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @naykun can you confirm if we need this config?

@a-r-r-o-w a-r-r-o-w merged commit 9a38fab into main Aug 4, 2025
13 of 15 checks passed
@a-r-r-o-w a-r-r-o-w deleted the tests/qwen-image branch August 4, 2025 10:58
@a-r-r-o-w a-r-r-o-w mentioned this pull request Aug 4, 2025
Merged
2 tasks
Beinsezii pushed a commit to Beinsezii/diffusers that referenced this pull request Aug 7, 2025
@a-r-r-o-w @Beinsezii
tests + minor refactor for QwenImage (huggingface#12057)
44185e9 
* update

* update

* update

* add docs
Beinsezii pushed a commit to Beinsezii/diffusers that referenced this pull request Aug 7, 2025
@a-r-r-o-w @Beinsezii
tests + minor refactor for QwenImage (huggingface#12057)
34a1e86 
* update

* update

* update

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-r-r-o-w @HuggingFaceDocBuilderDev @yiyixuxu