[tests] Add inference test slices for SD3 and remove unnecessary tests #12106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Aug 11, 2025
Comment on lines
-127
to
-141
| def test_stable_diffusion_3_different_prompts(self): | ||
| pipe = self.pipeline_class(**self.get_dummy_components()).to(torch_device) | ||
|
|
||
| inputs = self.get_dummy_inputs(torch_device) | ||
| output_same_prompt = pipe(**inputs).images[0] | ||
|
|
||
| inputs = self.get_dummy_inputs(torch_device) | ||
| inputs["prompt_2"] = "a different prompt" | ||
| inputs["prompt_3"] = "another different prompt" | ||
| output_different_prompts = pipe(**inputs).images[0] | ||
|
|
||
| max_diff = np.abs(output_same_prompt - output_different_prompts).max() | ||
|
|
||
| # Outputs should be different here | ||
| assert max_diff > 1e-2 |
There was a problem hiding this comment.
Makes sense to remove because we are not checking for any assertion slice. We don't get much issues for it, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for attention backend refactor, we should ensure that the inference slices match.
Also, there were some tests that don't make sense to test, so I removed those. Let me know if I should bring it back