Skip to content

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Nov 1, 2024

What does this PR do?

Follow-up of #9449. Also clubs #9821.

In short, this enables distributed inference when using LoRAs.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul marked this pull request as ready for review November 1, 2024 02:32
return ignore_patterns


def model_has_device_map(model):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most important bit to take note of. And I have added tests for it too (test_sharded_components_can_be_device_placed()).

@sayakpaul
Copy link
Member Author

Failing tests are unrelated.

@sayakpaul sayakpaul requested a review from DN6 November 1, 2024 04:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 1, 2024
@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Dec 1, 2024
@sayakpaul sayakpaul requested a review from yiyixuxu December 1, 2024 15:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues that haven't received updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants