Fix off-by-one error on safety condition in while loop (#454)

* Fix off-by-one error on safety condition in while loop

* Add test case

Although it seems that the core issue may be elsewhere,
as "transformers.training_args.__create_fn__.<locals>.__init__" is
a bit unexpected.

Author: tomaarsen

src/doc_builder/autodoc.py

@@ -78,7 +78,7 @@ def get_shortest_path(obj, package):
     path_splits = long_path.split(".")
     module = package
     idx = module.__name__.count(".")
-    while idx < len(path_splits) and not hasattr(module, short_name):
+    while idx + 1 < len(path_splits) and not hasattr(module, short_name):
         idx += 1
         module = getattr(module, path_splits[idx])
     return ".".join(path_splits[: idx + 1]) + "." + long_name

tests/test_autodoc.py

@@ -36,7 +36,7 @@
     remove_example_tags,
     resolve_links_in_text,
 )
-from transformers import BertModel, BertTokenizer, BertTokenizerFast
+from transformers import BertModel, BertTokenizer, BertTokenizerFast, TrainingArguments
 from transformers.utils import PushToHubMixin
 
 
@@ -170,6 +170,10 @@ def test_get_shortest_path(self):
         self.assertEqual(get_shortest_path(BertModel, transformers), "transformers.BertModel")
         self.assertEqual(get_shortest_path(BertModel.forward, transformers), "transformers.BertModel.forward")
         self.assertEqual(get_shortest_path(PushToHubMixin, transformers), "transformers.utils.PushToHubMixin")
+        self.assertEqual(
+            get_shortest_path(TrainingArguments.__init__, transformers),
+            "transformers.training_args.__create_fn__.<locals>.__init__",
+        )
 
     def test_get_type_name(self):
         self.assertEqual(get_type_name(str), "str")