Skip to content

Commit f311f16

Browse files
authored
[core] Fix loading of precomputed conditions and latents (#199)
* support precomputation. * fixes
1 parent 6716ccf commit f311f16

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

finetrainers/dataset.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,13 +353,18 @@ def _find_nearest_resolution(self, height, width):
353353

354354

355355
class PrecomputedDataset(Dataset):
356-
def __init__(self, data_root: str) -> None:
356+
def __init__(self, data_root: str, model_name: str = None, cleaned_model_id: str = None) -> None:
357357
super().__init__()
358358

359359
self.data_root = Path(data_root)
360360

361-
self.latents_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_LATENTS_DIR_NAME
362-
self.conditions_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_CONDITIONS_DIR_NAME
361+
if model_name and cleaned_model_id:
362+
precomputation_dir = self.data_root / f"{model_name}_{cleaned_model_id}_{PRECOMPUTED_DIR_NAME}"
363+
self.latents_path = precomputation_dir / PRECOMPUTED_LATENTS_DIR_NAME
364+
self.conditions_path = precomputation_dir / PRECOMPUTED_CONDITIONS_DIR_NAME
365+
else:
366+
self.latents_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_LATENTS_DIR_NAME
367+
self.conditions_path = self.data_root / PRECOMPUTED_DIR_NAME / PRECOMPUTED_CONDITIONS_DIR_NAME
363368

364369
self.latent_conditions = sorted(os.listdir(self.latents_path))
365370
self.text_conditions = sorted(os.listdir(self.conditions_path))

finetrainers/trainer.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,9 @@ def collate_fn(batch):
225225
if not should_precompute:
226226
logger.info("Precomputed conditions and latents found. Loading precomputed data.")
227227
self.dataloader = torch.utils.data.DataLoader(
228-
PrecomputedDataset(self.args.data_root),
228+
PrecomputedDataset(
229+
data_root=self.args.data_root, model_name=self.args.model_name, cleaned_model_id=cleaned_model_id
230+
),
229231
batch_size=self.args.batch_size,
230232
shuffle=True,
231233
collate_fn=collate_fn,
@@ -353,7 +355,9 @@ def collate_fn(batch):
353355

354356
# Update dataloader to use precomputed conditions and latents
355357
self.dataloader = torch.utils.data.DataLoader(
356-
PrecomputedDataset(self.args.data_root),
358+
PrecomputedDataset(
359+
data_root=self.args.data_root, model_name=self.args.model_name, cleaned_model_id=cleaned_model_id
360+
),
357361
batch_size=self.args.batch_size,
358362
shuffle=True,
359363
collate_fn=collate_fn,

0 commit comments

Comments
 (0)