Skip to content

Conversation

@Paul92
Copy link
Contributor

@Paul92 Paul92 commented Oct 6, 2022

Fixes #364.

As a first PR, I'd be grateful for some comments regarding the style and nature of the introductory content.

I plan to address a few of the remaining tasks (example code, example input/output, etc) in the meantime.

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for handling this! ❤️ I left minor nits 🙂

@osanseviero osanseviero self-requested a review October 6, 2022 19:50
@Paul92 Paul92 requested review from merveenoyan and removed request for osanseviero October 7, 2022 07:53
@Paul92
Copy link
Contributor Author

Paul92 commented Oct 7, 2022

I've been thinking what to share as a code example. Perhaps something along the lines of this low level enhancement app?

https://huggingface.co/spaces/keras-io/low-light-image-enhancement/blob/main/app.py

@Paul92 Paul92 marked this pull request as ready for review October 7, 2022 13:29
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @osanseviero can you check super quick?

demo: {
inputs: [
{
filename: "image-to-image-input.jpeg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
Ekran Resmi 2022-10-07 17 34 02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this repo still open for contribution?
Awesome work so far

Copy link
Contributor Author

@Paul92 Paul92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Paul92 Paul92 requested a review from merveenoyan October 8, 2022 22:17
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!

demo: {
inputs: [
{
filename: "image-to-image-input.jpeg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@merveenoyan
Copy link
Contributor

@Paul92 if you commit suggestion of osanseviero above I'm happy to merge your PR 🙂

@Paul92
Copy link
Contributor Author

Paul92 commented Oct 10, 2022

@merveenoyan Done. Thank you so much :)

@merveenoyan merveenoyan merged commit 4ac4223 into huggingface:main Oct 10, 2022
@merveenoyan
Copy link
Contributor

@Paul92 just merged. Can you give me your hugging face handle so I can add it at the end of the page to give you credits? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text-to-Image Task Page

4 participants