Do not make any extra API call when endpoint URL is directly specified (#1322)

coyotte508 · web-flow · commit 1a63901ea07f · 2025-04-09T16:21:45.000+02:00
Fix #1321 (cc @Kakulukian for viz) The fix is not perfect, a greater refactoring would need to take place (eg to remove all concept of `providerConfig` when `endpointUrl` is provided, use a separate default provider config maybe not relying on `model` being defined)
diff --git a/packages/inference/src/lib/makeRequestOptions.ts b/packages/inference/src/lib/makeRequestOptions.ts
@@ -35,6 +35,12 @@ export async function makeRequestOptions(
 	if (maybeModel && isUrl(maybeModel)) {
 		throw new Error(`Model URLs are no longer supported. Use endpointUrl instead.`);
 	}
+
+	if (args.endpointUrl) {
+		// No need to have maybeModel, or to load default model for a task
+		return makeRequestOptionsFromResolvedModel(maybeModel ?? args.endpointUrl, args, options);
+	}
+
 	if (!maybeModel && !task) {
 		throw new Error("No model provided, and no task has been specified.");
 	}

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,12 @@ export async function makeRequestOptions(`
`35`	`35`	`if (maybeModel && isUrl(maybeModel)) {`
`36`	`36`	throw new Error(`Model URLs are no longer supported. Use endpointUrl instead.`);
`37`	`37`	`}`
	`38`	`+`
	`39`	`+ if (args.endpointUrl) {`
	`40`	`+ // No need to have maybeModel, or to load default model for a task`
	`41`	`+ return makeRequestOptionsFromResolvedModel(maybeModel ?? args.endpointUrl, args, options);`
	`42`	`+ }`
	`43`	`+`
`38`	`44`	`if (!maybeModel && !task) {`
`39`	`45`	`throw new Error("No model provided, and no task has been specified.");`
`40`	`46`	`}`