Skip to content

Commit 1c21ff0

Browse files
committed
apply reviewer feedback (keep it as spec definition only and add snippet to tasks snippets)
1 parent 5e02493 commit 1c21ff0

File tree

6 files changed

+6
-43
lines changed

6 files changed

+6
-43
lines changed

packages/inference/src/lib/getProviderHelper.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import type {
2424
ImageSegmentationTaskHelper,
2525
ImageToImageTaskHelper,
2626
ImageToTextTaskHelper,
27-
ImageToVideoTaskHelper,
2827
ObjectDetectionTaskHelper,
2928
QuestionAnsweringTaskHelper,
3029
SentenceSimilarityTaskHelper,
@@ -220,10 +219,6 @@ export function getProviderHelper(
220219
provider: InferenceProviderOrPolicy,
221220
task: "image-to-text"
222221
): ImageToTextTaskHelper & TaskProviderHelper;
223-
export function getProviderHelper(
224-
provider: InferenceProviderOrPolicy,
225-
task: "image-to-video"
226-
): ImageToVideoTaskHelper & TaskProviderHelper;
227222
export function getProviderHelper(
228223
provider: InferenceProviderOrPolicy,
229224
task: "object-detection"

packages/inference/src/providers/providerHelper.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import type {
3434
TextToImageInput,
3535
TextToSpeechInput,
3636
TextToVideoInput,
37-
ImageToVideoInput,
3837
TokenClassificationInput,
3938
TokenClassificationOutput,
4039
TranslationInput,
@@ -148,11 +147,6 @@ export interface ImageToImageTaskHelper {
148147
preparePayloadAsync(args: ImageToImageArgs): Promise<RequestArgs>;
149148
}
150149

151-
export interface ImageToVideoTaskHelper {
152-
getResponse(response: unknown, url?: string, headers?: Record<string, string>): Promise<Blob>;
153-
preparePayload(params: BodyParams<ImageToVideoInput & BaseArgs>): Record<string, unknown>;
154-
}
155-
156150
export interface ImageSegmentationTaskHelper {
157151
getResponse(response: unknown, url?: string, headers?: HeadersInit): Promise<ImageSegmentationOutput>;
158152
preparePayload(params: BodyParams<ImageSegmentationInput & BaseArgs>): Record<string, unknown> | BodyInit;

packages/inference/src/snippets/getInferenceSnippets.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ const HF_PYTHON_METHODS: Partial<Record<WidgetType, string>> = {
8383
"image-segmentation": "image_segmentation",
8484
"image-to-image": "image_to_image",
8585
"image-to-text": "image_to_text",
86-
"image-to-video": "image_to_video",
8786
"object-detection": "object_detection",
8887
"question-answering": "question_answering",
8988
"sentence-similarity": "sentence_similarity",
@@ -110,7 +109,6 @@ const HF_JS_METHODS: Partial<Record<WidgetType, string>> = {
110109
"feature-extraction": "featureExtraction",
111110
"fill-mask": "fillMask",
112111
"image-classification": "imageClassification",
113-
"image-to-video": "imageToVideo",
114112
"question-answering": "questionAnswering",
115113
"sentence-similarity": "sentenceSimilarity",
116114
summarization: "summarization",
@@ -268,11 +266,6 @@ const prepareImageToImageInput = (model: ModelDataMinimal): object => {
268266
return { inputs: data.image, parameters: { prompt: data.prompt } };
269267
};
270268

271-
const prepareImageToVideoInput = (model: ModelDataMinimal): object => {
272-
const data = JSON.parse(getModelInputSnippet(model) as string);
273-
return { inputs: data.image, parameters: { prompt: data.prompt } };
274-
};
275-
276269
const prepareConversationalInput = (
277270
model: ModelDataMinimal,
278271
opts?: {
@@ -323,7 +316,6 @@ const snippets: Partial<
323316
"image-segmentation": snippetGenerator("basicImage"),
324317
"image-text-to-text": snippetGenerator("conversational"),
325318
"image-to-image": snippetGenerator("imageToImage", prepareImageToImageInput),
326-
"image-to-video": snippetGenerator("imageToVideo", prepareImageToVideoInput),
327319
"image-to-text": snippetGenerator("basicImage"),
328320
"object-detection": snippetGenerator("basicImage"),
329321
"question-answering": snippetGenerator("questionAnswering", prepareQuestionAnsweringInput),

packages/inference/src/tasks/cv/imageToVideo.ts

Lines changed: 0 additions & 23 deletions
This file was deleted.

packages/inference/src/tasks/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ export * from "./cv/imageToText";
1616
export * from "./cv/objectDetection";
1717
export * from "./cv/textToImage";
1818
export * from "./cv/textToVideo";
19-
export * from "./cv/imageToVideo";
2019
export * from "./cv/zeroShotImageClassification";
2120

2221
// Natural Language Processing tasks

packages/tasks/src/snippets/inputs.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ const inputsImageToImage = () => `{
9191
"prompt": "Turn the cat into a tiger."
9292
}`;
9393

94+
const inputsImageToVideo = () => `{
95+
"image": "cat.png",
96+
"prompt": "The cat starts to dance"
97+
}`;
98+
9499
const inputsImageSegmentation = () => `"cats.jpg"`;
95100

96101
const inputsObjectDetection = () => `"cats.jpg"`;
@@ -126,6 +131,7 @@ const modelInputSnippets: {
126131
"image-classification": inputsImageClassification,
127132
"image-to-text": inputsImageToText,
128133
"image-to-image": inputsImageToImage,
134+
"image-to-video": inputsImageToVideo,
129135
"image-segmentation": inputsImageSegmentation,
130136
"object-detection": inputsObjectDetection,
131137
"question-answering": inputsQuestionAnswering,

0 commit comments

Comments
 (0)