InferenceClient methods have the proper types now (#1410)

# TL;DR

Types of `InferenceClient` methods are now correct 🥳 

```typescript
const client = new InferenceClient();

const output = client.textToImage(
    {
        inputs: "test input",
        parameters: {
            /// Correctly typed! And auto-completion works!
        },
    },
    options
)
```

Author: SBrandeis

packages/inference/src/InferenceClient.ts

@@ -1,20 +1,13 @@
 import * as tasks from "./tasks";
-import type { Options, RequestArgs } from "./types";
-import type { DistributiveOmit } from "./utils/distributive-omit";
+import type { Options } from "./types";
 import { omit } from "./utils/omit";
+import { typedEntries } from "./utils/typedEntries";
 
 /* eslint-disable @typescript-eslint/no-empty-interface */
 /* eslint-disable @typescript-eslint/no-unsafe-declaration-merging */
 
 type Task = typeof tasks;
 
-type TaskWithNoAccessToken = {
-	[key in keyof Task]: (
-		args: DistributiveOmit<Parameters<Task[key]>[0], "accessToken">,
-		options?: Parameters<Task[key]>[1]
-	) => ReturnType<Task[key]>;
-};
-
 export class InferenceClient {
 	private readonly accessToken: string;
 	private readonly defaultOptions: Options;
@@ -28,15 +21,19 @@ export class InferenceClient {
 		this.accessToken = accessToken;
 		this.defaultOptions = defaultOptions;
 
-		for (const [name, fn] of Object.entries(tasks)) {
+		for (const [name, fn] of typedEntries(tasks)) {
 			Object.defineProperty(this, name, {
 				enumerable: false,
-				value: (params: RequestArgs, options: Options) =>
+				value: (params: Parameters<typeof fn>[0], options: Parameters<typeof fn>[1]) =>
 					// eslint-disable-next-line @typescript-eslint/no-explicit-any
-					fn({ endpointUrl: defaultOptions.endpointUrl, accessToken, ...params } as any, {
-						...omit(defaultOptions, ["endpointUrl"]),
-						...options,
-					}),
+					(fn as any)(
+						/// ^ The cast of fn to any is necessary, otherwise TS can't compile because the generated union type is too complex
+						{ endpointUrl: defaultOptions.endpointUrl, accessToken, ...params },
+						{
+							...omit(defaultOptions, ["endpointUrl"]),
+							...options,
+						}
+					),
 			});
 		}
 	}
@@ -51,7 +48,7 @@ export class InferenceClient {
 	}
 }
 
-export interface InferenceClient extends TaskWithNoAccessToken {}
+export interface InferenceClient extends Task {}
 
 /**
  * For backward compatibility only, will remove soon.

packages/inference/src/lib/getInferenceProviderMapping.ts

@@ -112,7 +112,10 @@ export async function resolveProvider(
 			throw new Error("Specifying a model is required when provider is 'auto'");
 		}
 		const inferenceProviderMapping = await fetchInferenceProviderMappingForModel(modelId);
-		provider = Object.keys(inferenceProviderMapping)[0] as InferenceProvider;
+		provider = Object.keys(inferenceProviderMapping)[0] as InferenceProvider | undefined;
+	}
+	if (!provider) {
+		throw new Error(`No Inference Provider available for model ${modelId}.`);
 	}
 	return provider;
 }

packages/inference/src/utils/typedEntries.ts

@@ -0,0 +1,5 @@
+export function typedEntries<T extends { [s: string]: T[keyof T] } | ArrayLike<T[keyof T]>>(
+	obj: T
+): [keyof T, T[keyof T]][] {
+	return Object.entries(obj) as [keyof T, T[keyof T]][];
+}

packages/inference/test/InferenceClient.spec.ts

@@ -294,7 +294,7 @@ describe.skip("InferenceClient", () => {
 					await hf.tableQuestionAnswering({
 						model: "google/tapas-base-finetuned-wtq",
 						inputs: {
-							query: "How many stars does the transformers repository have?",
+							question: "How many stars does the transformers repository have?",
 							table: {
 								Repository: ["Transformers", "Datasets", "Tokenizers"],
 								Stars: ["36542", "4512", "3934"],
@@ -488,7 +488,8 @@ describe.skip("InferenceClient", () => {
 				expect(
 					await hf.translation({
 						model: "t5-base",
-						inputs: ["My name is Wolfgang and I live in Berlin", "I work as programmer"],
+						// eslint-disable-next-line @typescript-eslint/no-explicit-any
+						inputs: ["My name is Wolfgang and I live in Berlin", "I work as programmer"] as any,
 					})
 				).toMatchObject([
 					{
@@ -505,7 +506,8 @@ describe.skip("InferenceClient", () => {
 						model: "facebook/bart-large-mnli",
 						inputs: [
 							"Hi, I recently bought a device from your company but it is not working as advertised and I would like to get reimbursed!",
-						],
+							// eslint-disable-next-line @typescript-eslint/no-explicit-any
+						] as any,
 						parameters: { candidate_labels: ["refund", "legal", "faq"] },
 					})
 				).toEqual(

packages/mcp-client/src/McpClient.ts

@@ -2,7 +2,7 @@ import { Client } from "@modelcontextprotocol/sdk/client/index.js";
 import type { StdioServerParameters } from "@modelcontextprotocol/sdk/client/stdio.js";
 import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
 import { InferenceClient } from "@huggingface/inference";
-import type { InferenceClientEndpoint, InferenceProvider } from "@huggingface/inference";
+import type { InferenceClientEndpoint, InferenceProviderOrPolicy } from "@huggingface/inference";
 import type {
 	ChatCompletionInputMessage,
 	ChatCompletionInputTool,
@@ -23,7 +23,7 @@ export interface ChatCompletionInputMessageTool extends ChatCompletionInputMessa
 
 export class McpClient {
 	protected client: InferenceClient | InferenceClientEndpoint;
-	protected provider: string | undefined;
+	protected provider: InferenceProviderOrPolicy | undefined;
 
 	protected model: string;
 	private clients: Map<ToolName, Client> = new Map();
@@ -36,7 +36,7 @@ export class McpClient {
 		apiKey,
 	}: (
 		| {
-				provider: InferenceProvider;
+				provider: InferenceProviderOrPolicy;
 				baseUrl?: undefined;
 		  }
 		| {