Skip to content

add CLIP-ViT-L-scope #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 10 commits into from
Nov 19, 2024
Merged

add CLIP-ViT-L-scope #1022

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc2619f
add CLIP-ViT-L-scope
Lewington-pitsos Nov 12, 2024
37993bf
make names more consistent, point to usable repo
Lewington-pitsos Nov 14, 2024
57591e3
Update packages/tasks/src/model-libraries.ts
Lewington-pitsos Nov 19, 2024
f514f06
Merge branch 'main' into main
Lewington-pitsos Nov 19, 2024
9c81bb8
Update packages/tasks/src/model-libraries.ts
Wauplin Nov 19, 2024
ff97299
Merge branch 'main' into main
Wauplin Nov 19, 2024
ce32d18
Update packages/tasks/src/model-libraries.ts
Wauplin Nov 19, 2024
0d321d5
Update packages/tasks/src/model-libraries.ts
Wauplin Nov 19, 2024
d1ea6b5
Update packages/tasks/src/model-libraries.ts
Wauplin Nov 19, 2024
48c6cad
Merge branch 'main' into main
Wauplin Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
repoUrl: "https://github.com/cartesia-ai/cartesia_mlx",
snippets: snippets.cartesia_mlx,
},
"clip-scope": {
prettyLabel: "CLIP-ViT-L-scope",
repoName: "CLIP-ViT-L-scope",
repoUrl: "https://github.com/Lewington-pitsos/vitsae",
Copy link
Contributor

@Wauplin Wauplin Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lewington-pitsos, thanks for opening a PR :) Just to understand, what is the library here? For what I can see:

  • clip-scope seems like a generic name that is not mentioned in both the model card and the github repo
  • clipscope seems to be a Python library ("from clipscope import ConfiguredViT, TopKSAE" in the model card) but can't see how to install it. At least it doesn't seem to be on PyPI.
  • CLIP-ViT-L-scope is a very specific name (the name of the repo on the Hub)
  • vitsae is the name of the repo on the Hub. Is it planned to be a published library at some point?

I'm asking this because depending on what you plan to do here, the integration with the Hub could change. Typically, do you think other repos might use the same library in the future or will it be a "one-shot"? We usually recommend to have a consistent naming between the library and repo tags to avoid confusion. Also, the name of the library is usually different from the name of the repo on the Hub, especially when multiple models are linked to the same library.

filter: false,
countDownloads: `path_extension:"pt"`,
},
cotracker: {
prettyLabel: "CoTracker",
repoName: "CoTracker",
Expand Down