Finally rename HfInference to InferenceClient
#1258
Conversation
julien-c
requested review from
SBrandeis,
Wauplin,
coyotte508,
gary149,
hanouticelina,
ngxson,
nsarrazin and
pcuenca
as code owners
There was a problem hiding this comment.
@julien-c to update these snippets, you have to:
cd packages/tasks-gen
pnpm i
pnpm run generate-snippets-fixtures
=> otherwise you'll have conflicts with the formatting. Typically all the , and ; added don't come from the generation code but from your autoformatter I think
|
oh that was by accident, I thought I was on a different PR 😮💨 |
@coyotte508 does this look ok? i don't know what i'm doing
| /** | ||
| * For backward compatibility only. | ||
| */ | ||
| export class HfInference extends InferenceClient {} |
There was a problem hiding this comment.
backward compatibility line ^
There was a problem hiding this comment.
do you have a preference vs. export const HfInference = InferenceClient; maybe @coyotte508?
Otherwise i'll merge
There was a problem hiding this comment.
Maybe you could have slapped @deprecated on it
There was a problem hiding this comment.
/**
* @deprecated use YYY instead
*/
class XXX {
}
It will strike through in the editor everytime X is called
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
CI failure is unrelated/transient (and i get a different failure each time 🥳). I'll try to make it pass one more time then i'll give up. In any case, ready for review! |
|
yay! i got lucky |
7 participants
There's no reason the API should be ≠ in Python and JS