Skip to content

Add MAGI-1 library #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 5 commits into from
May 28, 2025
Merged

Add MAGI-1 library #1386

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ef4565
Add MAGI-1 library
jiahy0825 Apr 25, 2025
fbdb6f3
update default value
jiahy0825 Apr 25, 2025
e8d8e57
Merge branch 'main' into add-magi-1
jiahy0825 Apr 27, 2025
03370c7
Merge branch 'main' into add-magi-1
Wauplin May 20, 2025
e7cca10
update countDownloads path
jiahy0825 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,12 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
repoName: "mindspore",
repoUrl: "https://github.com/mindspore-ai/mindspore",
},
"magi-1": {
Copy link
Contributor

@Wauplin Wauplin May 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @Vaibhavs10 mentioned, you'll need to set library_name: "magi-1" in your model card metadata to make this work

Copy link
Contributor Author

@jiahy0825 jiahy0825 May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice and I have set library_name: "magi-1" in the model card. Does the appearance of the symbol in the image mean the settings are correct?

image

Copy link
Contributor

@Wauplin Wauplin May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

prettyLabel: "MAGI-1",
repoName: "MAGI-1",
repoUrl: "https://github.com/SandAI-org/MAGI-1",
countDownloads: `path_extension:"json"`,
Copy link
Contributor

@Wauplin Wauplin May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this will likely double-count many downloads since there are several .json files needed to instantiate a model. What we usually do is to track downloads on a single file that is essential for the model to be loaded correctly. Could https://huggingface.co/sand-ai/MAGI-1/blob/main/ckpt/vae/config.json be used for that for instance?

Copy link
Contributor Author

@jiahy0825 jiahy0825 May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice and I have changed the path to ckpt/vae/config.json

},
"mamba-ssm": {
prettyLabel: "MambaSSM",
repoName: "MambaSSM",
Expand Down