Track download stats for the ACE-Step repo. #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DumoeDss
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
Vaibhavs10
reviewed
May 18, 2025
Contributor
Vaibhavs10
left a comment
Vaibhavs10
left a comment
There was a problem hiding this comment.
Thanks for the PR @DumoeDss - few nits and we should be golden, I'm not sure why the library is set to diffusers in the repo: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B when it actually uses the acestep model library: https://github.com/ace-step/ACE-Step/blob/74121a5d8a9af2fd651ba70869e78868442f6329/infer.py#L4
let's fix that too please! 🙏
Wauplin
approved these changes
May 28, 2025
Contributor
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
All good ! I took care of tracking downloads by path:"ace_step_transformer/config.json" which is the correct way according to your comment + fix styling issue and alphabetical order.
Time to merge :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.