Add SSR-Speech as lib for download stats #904
Conversation
WangHelin1997
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
osanseviero and
pcuenca
as code owners
|
can you update the PR's title and description @WangHelin1997? Thanks! |
There was a problem hiding this comment.
Hi @WangHelin1997 - Thanks for your PR, as mentioned above please update the Title and add a simple description.
On a quick review, first of all I opened a PR on your English model repo: https://huggingface.co/westbrook/SSR-Speech-English/discussions/1
This PR will make allow the model downloads to be tracked actually, we need the repos to be associated with the tag (in this case ssr-speech) - this will be handy when you release your Mandarin checkpoint as well.
Next, please make sure that the Hub model repo has a well documented README: https://huggingface.co/westbrook/SSR-Speech-English (you can copy information from your github repo as well)
It might be worth adding a model snippet here as well, ref: https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/model-libraries-snippets.ts
WangHelin1997
changed the title
WangHelin1997
changed the title
There was a problem hiding this comment.
Hi @WangHelin1997, thanks for clarifying the PR! I've left a few comments, after that we should be good to merge!
There was a problem hiding this comment.
Thanks for the changes @WangHelin1997! Everything looks good to me now 🤗
I'll let @Vaibhavs10 confirm and merge the PR :)
4 participants
Hi, I want to add the model SSR-Speech as a library for download stats. Thanks!
The huggingface repos are https://huggingface.co/westbrook/SSR-Speech-Mandarin and https://huggingface.co/westbrook/SSR-Speech-English