Skip to content

Add T5-TTS library #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wauplin merged 6 commits into from
Oct 15, 2024
Merged

Add T5-TTS library #965

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f3c2b86
Add library
NielsRogge Oct 14, 2024
1f441e5
Update packages/tasks/src/model-libraries.ts
NielsRogge Oct 14, 2024
1bb00b0
Update path_extension
NielsRogge Oct 14, 2024
2d5ef28
Merge branch 'add_t5_tts' of github.com:NielsRogge/huggingface.js int…
NielsRogge Oct 14, 2024
376ef04
Merge remote-tracking branch 'upstream/main' into add_t5_tts
NielsRogge Oct 15, 2024
699417c
Update path_extension
NielsRogge Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/tasks/src/model-libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
filter: true,
countDownloads: `path:"models/default.zip"`,
},
"t5-tts": {
prettyLabel: "T5-TTS",
repoName: "T5-TTS",
repoUrl: "https://github.com/SWivid/F5-TTS",
filter: false,
countDownloads: `path_extension:"safetensors" OR path_extension:"pt"`,
Copy link
Contributor

@Wauplin Wauplin Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why they went for a solution with both E2_TTS and F5_TTS in the same repo? Doing so doesn't allow for separate counting. If you are in contact with them, would be good to nudge them to split.

The current download rule looks good though, no matter if the models get split in 2 repos are not.

Copy link
Contributor Author

@NielsRogge NielsRogge Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @SWivid would you like to have separate download counts for the E2_TTS and F5_TTS checkpoints?

If yes, then it makes sense to split them up into 2 separate model repositories.

Copy link

@SWivid SWivid Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it influences the current spaces using it ?
If not, would like to split it up, otherwise thought it's just OK for having F5 and reproduce E2 there

Copy link
Contributor Author

@NielsRogge NielsRogge Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes so the current Spaces are assuming both are present in the same model repo, see e.g. https://huggingface.co/spaces/mrfakename/E2-F5-TTS/blob/main/app.py#L53.

So updating that would break existing Spaces

Copy link
Contributor

@Wauplin Wauplin Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I would suggest is:

  1. create a new repo for E2-TTS with E2 checkpoints
  2. open a PR on https://huggingface.co/spaces/mrfakename/E2-F5-TTS to point to the new repo
  3. remove the E2-TTS weights from F5-TTS repo

Copy link
Contributor

@Vaibhavs10 Vaibhavs10 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Seperate repos would be better.

Copy link
Contributor Author

@NielsRogge NielsRogge Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, @SWivid would you be up for that?

Copy link

@SWivid SWivid Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, i'll take care of it

Copy link

@SWivid SWivid Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsRogge sorry for the delay, just got repo split and E2 removed from F5 repo.

Copy link
Contributor Author

@NielsRogge NielsRogge Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that both model repos would require library_name: f5-tts for downloads to work.

},
tensorflowtts: {
prettyLabel: "TensorFlowTTS",
repoName: "TensorFlowTTS",
Expand Down