Skip to content

Commit 0467c1c

Browse files
authored
Fix test_dataset_info (missing dummy dataset) (#2850)
1 parent 632c04f commit 0467c1c

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

tests/test_hf_api.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2164,20 +2164,17 @@ def test_dataset_info(self):
21642164
dataset = self._api.dataset_info(repo_id=DUMMY_DATASET_ID)
21652165
assert isinstance(dataset.card_data, DatasetCardData) and len(dataset.card_data) > 0
21662166
assert isinstance(dataset.siblings, list) and len(dataset.siblings) > 0
2167-
self.assertIsInstance(dataset, DatasetInfo)
2168-
self.assertNotEqual(dataset.sha, DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT)
2167+
assert isinstance(dataset, DatasetInfo)
2168+
assert dataset.sha != DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT
21692169
dataset = self._api.dataset_info(
21702170
repo_id=DUMMY_DATASET_ID,
21712171
revision=DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT,
21722172
)
2173-
self.assertIsInstance(dataset, DatasetInfo)
2174-
self.assertEqual(dataset.sha, DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT)
2173+
assert isinstance(dataset, DatasetInfo)
2174+
assert dataset.sha == DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT
21752175

21762176
def test_dataset_info_with_file_metadata(self):
2177-
dataset = self._api.dataset_info(
2178-
repo_id=SAMPLE_DATASET_IDENTIFIER,
2179-
files_metadata=True,
2180-
)
2177+
dataset = self._api.dataset_info(repo_id=SAMPLE_DATASET_IDENTIFIER, files_metadata=True)
21812178
files = dataset.siblings
21822179
assert files is not None
21832180
self._check_siblings_metadata(files)

tests/testing_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@
4747

4848
SAMPLE_DATASET_IDENTIFIER = "lhoestq/custom_squad"
4949
# Example dataset ids
50-
DUMMY_DATASET_ID = "lhoestq/test"
51-
DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT = "81d06f998585f8ee10e6e3a2ea47203dc75f2a16" # on branch "test-branch"
50+
DUMMY_DATASET_ID = "gaia-benchmark/GAIA"
51+
DUMMY_DATASET_ID_REVISION_ONE_SPECIFIC_COMMIT = "c603981e170e9e333934a39781d2ae3a2677e81f" # on branch "test-branch"
5252

5353
YES = ("y", "yes", "t", "true", "on", "1")
5454
NO = ("n", "no", "f", "false", "off", "0")

0 commit comments

Comments
 (0)