Skip to content

Commit 627fdb2

Browse files
Update contribution guide for merging PRs (#856)
* Update CONTRIBUTING.md * apply adrin review Co-authored-by: Adrin Jalali <[email protected]> Co-authored-by: Adrin Jalali <[email protected]>
1 parent dabcc83 commit 627fdb2

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,15 +215,17 @@ Follow these steps to start contributing:
215215
$ git push -u origin a-descriptive-name-for-my-changes
216216
```
217217

218-
7. Once you are satisfied (**and the checklist below is happy too**), go to the
218+
6. Once you are satisfied (**and the checklist below is happy too**), go to the
219219
webpage of your fork on GitHub. Click on 'Pull request' to send your changes
220220
to the project maintainers for review.
221221

222-
8. It's ok if maintainers ask you for changes. It happens to core contributors
222+
7. It's ok if maintainers ask you for changes. It happens to core contributors
223223
too! So everyone can see the changes in the Pull request, work in your local
224224
branch and push the changes to your fork. They will automatically appear in
225225
the pull request.
226-
226+
227+
8. Once your changes have been approved, one of the project maintainers will
228+
merge your pull request for you.
227229

228230
### Checklist
229231

0 commit comments

Comments
 (0)