Remove deprecations (#910)

* Remove deprecations

* Typo

* Update src/huggingface_hub/README.md

Co-authored-by: Julien Chaumond <[email protected]>

Co-authored-by: Julien Chaumond <[email protected]>

Author: LysandreJik

src/huggingface_hub/README.md

@@ -97,9 +97,9 @@ programmatic way of creating a repo, deleting it (`⚠️ caution`), pushing a
 single file to a repo or listing models from the Hub, you'll find helpers in
 `hf_api.py`. Some example functionality available with the `HfApi` class:
 
-* `login()`
+* `set_access_token()`
+* `unset_access_token()`
 * `whoami()`
-* `logout()`
 * `create_repo()`
 * `list_repo_files()`
 * `list_repo_objects()`

src/huggingface_hub/_snapshot_download.py

@@ -7,7 +7,6 @@
 from .file_download import REGEX_COMMIT_HASH, hf_hub_download, repo_folder_name
 from .hf_api import HfApi, HfFolder
 from .utils import logging
-from .utils._deprecation import _deprecate_positional_args
 
 
 logger = logging.get_logger(__name__)
@@ -39,7 +38,6 @@ def _filter_repo_files(
     return filtered_files
 
 
-@_deprecate_positional_args
 def snapshot_download(
     repo_id: str,
     *,

src/huggingface_hub/commands/user.py

@@ -168,18 +168,11 @@ def run(self):
         _|    _|    _|_|      _|_|_|    _|_|_|  _|_|_|  _|      _|    _|_|_|      _|        _|    _|    _|_|_|  _|_|_|_|
 
         To login, `huggingface_hub` now requires a token generated from https://huggingface.co/settings/tokens .
-        (Deprecated, will be removed in v0.3.0) To login with username and password instead, interrupt with Ctrl+C.
         """
         )
 
-        try:
-            token = getpass("Token: ")
-            _login(self._api, token=token)
-
-        except KeyboardInterrupt:
-            username = input("\rUsername: ")
-            password = getpass()
-            _login(self._api, username, password)
+        token = getpass("Token: ")
+        _login(self._api, token=token)
 
 
 class WhoamiCommand(BaseUserCommand):
@@ -208,12 +201,6 @@ def run(self):
             exit()
         HfFolder.delete_token()
         HfApi.unset_access_token()
-        try:
-            self._api.logout(token)
-        except HTTPError as e:
-            # Logging out with an access token will return a client error.
-            if not e.response.status_code == 400:
-                raise e
         print("Successfully logged out.")
 
 
@@ -304,9 +291,7 @@ def run(self):
 NOTEBOOK_LOGIN_TOKEN_HTML_END = """
 <b>Pro Tip:</b> If you don't already have one, you can create a dedicated
 'notebooks' token with 'write' access, that you can then easily reuse for all
-notebooks. <br> <i>Logging in with your username and password is deprecated and
-won't be possible anymore in the near future. You can still use them for now by
-clicking below.</i> </center>"""
+notebooks. </center>"""
 
 
 def notebook_login():
@@ -328,34 +313,18 @@ def notebook_login():
 
     token_widget = widgets.Password(description="Token:")
     token_finish_button = widgets.Button(description="Login")
-    switch_button = widgets.Button(description="Use password")
 
     login_token_widget = widgets.VBox(
         [
             widgets.HTML(NOTEBOOK_LOGIN_TOKEN_HTML_START),
             token_widget,
             token_finish_button,
             widgets.HTML(NOTEBOOK_LOGIN_TOKEN_HTML_END),
-            switch_button,
         ],
         layout=box_layout,
     )
     display(login_token_widget)
 
-    # Deprecated page for login
-    input_widget = widgets.Text(description="Username:")
-    password_widget = widgets.Password(description="Password:")
-    password_finish_button = widgets.Button(description="Login")
-
-    login_password_widget = widgets.VBox(
-        [
-            widgets.HTML(value=NOTEBOOK_LOGIN_PASSWORD_HTML),
-            widgets.HBox([input_widget, password_widget]),
-            password_finish_button,
-        ],
-        layout=box_layout,
-    )
-
     # On click events
     def login_token_event(t):
         token = token_widget.value
@@ -366,35 +335,9 @@ def login_token_event(t):
 
     token_finish_button.on_click(login_token_event)
 
-    def login_password_event(t):
-        username = input_widget.value
-        password = password_widget.value
-        # Erase password and clear value to make sure it's not saved in the notebook.
-        password_widget.value = ""
-        clear_output()
-        _login(HfApi(), username=username, password=password)
-
-    password_finish_button.on_click(login_password_event)
-
-    def switch_event(t):
-        clear_output()
-        display(login_password_widget)
-
-    switch_button.on_click(switch_event)
-
-
-def _login(hf_api, username=None, password=None, token=None):
-    if token is None:
-        try:
-            token = hf_api.login(username, password)
-        except HTTPError as e:
-            # probably invalid credentials, display error message.
-            print(e)
-            print(ANSI.red(e.response.text))
-            exit(1)
-    else:
-        token, name = hf_api._validate_or_retrieve_token(token)
 
+def _login(hf_api, token=None):
+    token, name = hf_api._validate_or_retrieve_token(token)
     hf_api.set_access_token(token)
     HfFolder.save_token(token)
     print("Login successful")

src/huggingface_hub/file_download.py

@@ -34,7 +34,6 @@
 )
 from .hf_api import HfFolder
 from .utils import logging
-from .utils._deprecation import _deprecate_positional_args
 from .utils._errors import _raise_for_status
 
 
@@ -151,7 +150,6 @@ def get_fastcore_version():
 REGEX_COMMIT_HASH = re.compile(r"^[0-9a-f]{40}$")
 
 
-@_deprecate_positional_args
 def hf_hub_url(
     repo_id: str,
     filename: str,
@@ -310,7 +308,6 @@ def filename_to_url(
     return url, etag
 
 
-@_deprecate_positional_args
 def http_user_agent(
     *,
     library_name: Optional[str] = None,
@@ -425,7 +422,6 @@ def _request_with_retry(
     return response
 
 
-@_deprecate_positional_args
 def http_get(
     url: str,
     temp_file: BinaryIO,
@@ -469,7 +465,6 @@ def http_get(
     progress.close()
 
 
-@_deprecate_positional_args
 def cached_download(
     url: str,
     *,
@@ -800,7 +795,6 @@ def repo_folder_name(*, repo_id: str, repo_type: str) -> str:
     return REPO_ID_SEPARATOR.join(parts)
 
 
-@_deprecate_positional_args
 def hf_hub_download(
     repo_id: str,
     filename: str,