fix(windows): remove the typo in preambule and remove duplicated add_compile_definition in windows.cmake

mfuntowicz · mfuntowicz · commit cdd0f7078829 · 2025-11-19T14:36:09.000+01:00
diff --git a/build2cmake/src/templates/cuda/preamble.cmake b/build2cmake/src/templates/cuda/preamble.cmake
@@ -107,7 +107,7 @@ include(${CMAKE_CURRENT_LIST_DIR}/cmake/windows.cmake)
 # This preprocessor macro should be defined in building with MSVC but not for CUDA and co.
 # Also, if not using MVSC, this may not be set too ...
 # So we explicitly set it to avoid any side effect due to preprocessor-guards not being defined.
-add_compile_definitions(_WIN32>)
+add_compile_definitions(_WIN32)
 
 # Generate standardized build name
 run_python(TORCH_VERSION "import torch; print(torch.__version__.split('+')[0])" "Failed to get Torch version")
diff --git a/build2cmake/src/templates/windows.cmake b/build2cmake/src/templates/windows.cmake
@@ -1,6 +1,3 @@
-# Ensure _WIN32 is always defined on Windows
-add_compile_definitions(_WIN32)
-
 # Generate a standardized build variant name following the pattern:
 # torch<VERSION>-<ABI>-<COMPUTE>-windows
 #

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,3 @@`
`1`		`-# Ensure _WIN32 is always defined on Windows`
`2`		`-add_compile_definitions(_WIN32)`
`3`		`-`
`4`	`1`	`# Generate a standardized build variant name following the pattern:`
`5`	`2`	`# torch<VERSION>-<ABI>-<COMPUTE>-windows`
`6`	`3`	`#`