Skip to content

sana support #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 30, 2025
Merged

sana support #1106

merged 15 commits into from
Jan 30, 2025

Conversation

@eaidova
Copy link
Contributor

@eaidova eaidova commented Jan 13, 2025 •
edited
Loading

What does this PR do?

  • provided opportunity to select model checkpoint variant for loading
  • supported Sana image generation model family

Example of usage:

import torch

from optimum.intel.openvino import OVDiffusionPipeline


pipe = OVDiffusionPipeline.from_pretrained("Efficient-Large-Model/Sana_600M_512px_diffusers", variant="fp16")
prompt = 'a cyberpunk cat in neon style'
image = pipe(
    prompt=prompt,
    generator=torch.Generator(device="cpu").manual_seed(142),
)[0]

image[0].save("sana_fp16.png")

Generated image:
sana_fp16

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

eaidova
eaidova commented Jan 13, 2025
View reviewed changes
@eaidova eaidova changed the title Ea/sana support sana support Jan 13, 2025
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova marked this pull request as ready for review January 17, 2025 08:10
eaidova
eaidova commented Jan 17, 2025
View reviewed changes
@andrei-kochin
Copy link

@echarlaix @IlyasMoutawwakil could you please take a look?

IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 27, 2025
View reviewed changes
@eaidova
Copy link
Contributor Author

eaidova commented Jan 30, 2025 •
edited
Loading

@IlyasMoutawwakil all comments applied (failed test is not related and already fixed on main), could you please take a look one more time?
Thanks!

IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
IlyasMoutawwakil
IlyasMoutawwakil reviewed Jan 30, 2025
View reviewed changes
@eaidova @IlyasMoutawwakil
Apply suggestions from code review
a9a64c6 
Co-authored-by: Ilyas Moutawwakil <[email protected]>
echarlaix
echarlaix reviewed Jan 30, 2025
View reviewed changes
echarlaix
echarlaix reviewed Jan 30, 2025
View reviewed changes
echarlaix
echarlaix approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @eaidova

@echarlaix echarlaix merged commit 78a74ce into huggingface:main Jan 30, 2025
22 checks passed
@nikita-savelyevv nikita-savelyevv mentioned this pull request Jul 7, 2025
Open
openvino-dev-samples
openvino-dev-samples reviewed Jul 8, 2025
View reviewed changes
tests/openvino/test_quantization.py
[
(OVStableDiffusion3Pipeline, "stable-diffusion-3", 9, 65),
(OVFluxPipeline, "flux", 7, 56),
(OVSanaPipeline, "sana", 19, 53),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikita-savelyevv any idea to get these predefined num of quantized node ?

Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openvino-dev-samples For example, you can run the newly added test locally and see how many reference nodes there are based on an assertion error.

@IlyasMoutawwakil IlyasMoutawwakil mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@echarlaix echarlaix echarlaix approved these changes

@IlyasMoutawwakil IlyasMoutawwakil IlyasMoutawwakil approved these changes

@nikita-savelyevv nikita-savelyevv Awaiting requested review from nikita-savelyevv

+2 more reviewers

@openvino-dev-samples openvino-dev-samples openvino-dev-samples left review comments

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@eaidova @HuggingFaceDocBuilderDev @andrei-kochin @nikita-savelyevv @AlexKoff88 @IlyasMoutawwakil @echarlaix @openvino-dev-samples