Fix error for grok-4/grok-3-mini not supporting the stop parameter (#1766)

Author: suryabdev

src/smolagents/models.py

@@ -368,8 +368,11 @@ def supports_stop_parameter(model_id: str) -> bool:
         bool: True if the model supports the stop parameter, False otherwise
     """
     model_name = model_id.split("/")[-1]
-    # o3, o4-mini, and the gpt-5 series (including versioned variants, o3-2025-04-16) don't support stop parameter
-    pattern = r"^(o3[-\d]*|o4-mini[-\d]*|gpt-5(-mini|-nano)?[-\d]*)$"
+    # o3, o4-mini, grok-3-mini, grok-4, grok-code-fast and the gpt-5 series (including versioned variants, o3-2025-04-16) don't support stop parameter
+    openai_model_pattern = r"(o3[-\d]*|o4-mini[-\d]*|gpt-5(-mini|-nano)?[-\d]*)"
+    grok_model_pattern = r"([a-zA-Z]+\.)?(grok-3-mini|grok-4|grok-code-fast)(-[A-Za-z0-9]*)?"
+    pattern = rf"^({openai_model_pattern}|{grok_model_pattern})$"
+
     return not re.match(pattern, model_name)
 
 

tests/test_models.py

@@ -754,6 +754,13 @@ def test_flatten_messages_as_text_for_all_models(
         # Unsupported base models
         ("o3", False),
         ("o4-mini", False),
+        ("gpt-5", False),
+        ("gpt-5-mini", False),
+        ("gpt-5-nano", False),
+        ("grok-4", False),
+        ("grok-4-latest", False),
+        ("grok-3-mini", False),
+        ("grok-code-fast-1", False),
         # Unsupported versioned models
         ("o3-2025-04-16", False),
         ("o4-mini-2025-04-16", False),
@@ -762,12 +769,16 @@ def test_flatten_messages_as_text_for_all_models(
         ("openai/o4-mini", False),
         ("openai/o3-2025-04-16", False),
         ("openai/o4-mini-2025-04-16", False),
+        ("oci/xai.grok-4", False),
+        ("oci/xai.grok-3-mini", False),
         # Supported models
         ("o3-mini", True),  # Different from o3
         ("o3-mini-2025-01-31", True),  # Different from o3
         ("o4", True),  # Different from o4-mini
         ("o4-turbo", True),  # Different from o4-mini
         ("gpt-4", True),
+        ("gpt-5-turbo", True),  # Different from gpt-5
+        ("grok-3", True),  # Different from grok-3-mini
         ("claude-3-5-sonnet", True),
         ("mistral-large", True),
         # Supported models with path prefixes