Disable Flash Attention with USE_FLASH_ATTENTION
#692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR handles the value for the environment variable
USE_FLASH_ATTENTION
when applicable, so that Flash Attention can be disabled, as it's known to be problematic on Turing.This being said, even if the
USE_FLASH_ATTENTION
environment variable was already there, it was not handled for some cases such as Qwen2, Qwen3, or GTE; neither for Mistral which won't support it, but still raising an error if provided.Fixes #644 #347
Before submitting
Who can review?
@Narsil
Additional notes
Maybe it's a nice time to update the documentation around this issue, as there are similar reports of numerical instability / null or empty vectors when running on Turing, which is expected, but maybe the documentation could be more clear around it if so many users report the same issues; which I can do as part of this PR if needed 🤗