Skip to content

Commit 617b212

Browse files
McPatateMcPatate
authored
fix(ci): benchmarks dashboard was failing due to missing quotations (#34100)
1 parent 144852f commit 617b212

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

‎benchmark/grafana_dashboard.json‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@
148148
"editorMode": "code",
149149
"format": "table",
150150
"rawQuery": true,
151-
"rawSql": "SELECT commit_id as commit_id, commit_message, gpu_name FROM benchmarks WHERE branch = ${branch};",
151+
"rawSql": "SELECT commit_id as commit_id, commit_message, gpu_name FROM benchmarks WHERE branch = '${branch}';",
152152
"refId": "A",
153153
"sql": {
154154
"columns": [
@@ -283,7 +283,7 @@
283283
"id": 7,
284284
"options": {
285285
"barRadius": 0.05,
286-
"barWidth": 0.3,
286+
"barWidth": 0.8,
287287
"fullHighlight": false,
288288
"groupWidth": 0.7,
289289
"legend": {
@@ -312,7 +312,7 @@
312312
"editorMode": "code",
313313
"format": "table",
314314
"rawQuery": true,
315-
"rawSql": "SELECT CAST(m.measurements->'first_eager_forward_pass_time_secs' AS double precision) AS first_eager_forward_pass_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
315+
"rawSql": "SELECT CAST(m.measurements->'first_eager_forward_pass_time_secs' AS double precision) AS first_eager_forward_pass_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
316316
"refId": "A",
317317
"sql": {
318318
"columns": [
@@ -424,7 +424,7 @@
424424
"editorMode": "code",
425425
"format": "table",
426426
"rawQuery": true,
427-
"rawSql": "SELECT CAST(m.measurements->'second_eager_forward_pass_time_secs' AS double precision) AS second_eager_forward_pass_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
427+
"rawSql": "SELECT CAST(m.measurements->'second_eager_forward_pass_time_secs' AS double precision) AS second_eager_forward_pass_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
428428
"refId": "A",
429429
"sql": {
430430
"columns": [
@@ -545,7 +545,7 @@
545545
"editorMode": "code",
546546
"format": "table",
547547
"rawQuery": true,
548-
"rawSql": "SELECT CAST(m.measurements->'time_to_first_token_secs' AS double precision) AS time_to_first_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
548+
"rawSql": "SELECT CAST(m.measurements->'time_to_first_token_secs' AS double precision) AS time_to_first_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
549549
"refId": "A",
550550
"sql": {
551551
"columns": [
@@ -653,7 +653,7 @@
653653
"editorMode": "code",
654654
"format": "table",
655655
"rawQuery": true,
656-
"rawSql": "SELECT CAST(m.measurements->'time_to_second_token_secs' AS double precision) AS time_to_second_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
656+
"rawSql": "SELECT CAST(m.measurements->'time_to_second_token_secs' AS double precision) AS time_to_second_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
657657
"refId": "A",
658658
"sql": {
659659
"columns": [
@@ -761,7 +761,7 @@
761761
"editorMode": "code",
762762
"format": "table",
763763
"rawQuery": true,
764-
"rawSql": "SELECT CAST(m.measurements->'time_to_third_token_secs' AS double precision) AS time_to_third_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
764+
"rawSql": "SELECT CAST(m.measurements->'time_to_third_token_secs' AS double precision) AS time_to_third_token_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
765765
"refId": "A",
766766
"sql": {
767767
"columns": [
@@ -869,7 +869,7 @@
869869
"editorMode": "code",
870870
"format": "table",
871871
"rawQuery": true,
872-
"rawSql": "SELECT CAST(m.measurements->'time_to_next_token_mean_secs' AS double precision) AS time_to_next_token_mean_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
872+
"rawSql": "SELECT CAST(m.measurements->'time_to_next_token_mean_secs' AS double precision) AS time_to_next_token_mean_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
873873
"refId": "A",
874874
"sql": {
875875
"columns": [
@@ -990,7 +990,7 @@
990990
"editorMode": "code",
991991
"format": "table",
992992
"rawQuery": true,
993-
"rawSql": "SELECT CAST(m.measurements->'first_compile_generate_time_secs' AS double precision) AS first_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}'",
993+
"rawSql": "SELECT CAST(m.measurements->'first_compile_generate_time_secs' AS double precision) AS first_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}'",
994994
"refId": "A",
995995
"sql": {
996996
"columns": [
@@ -1098,7 +1098,7 @@
10981098
"editorMode": "code",
10991099
"format": "table",
11001100
"rawQuery": true,
1101-
"rawSql": "SELECT CAST(m.measurements->'second_compile_generate_time_secs' AS double precision) AS second_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}';",
1101+
"rawSql": "SELECT CAST(m.measurements->'second_compile_generate_time_secs' AS double precision) AS second_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}';",
11021102
"refId": "A",
11031103
"sql": {
11041104
"columns": [
@@ -1206,7 +1206,7 @@
12061206
"editorMode": "code",
12071207
"format": "table",
12081208
"rawQuery": true,
1209-
"rawSql": "SELECT CAST(m.measurements->'third_compile_generate_time_secs' AS double precision) AS third_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}';",
1209+
"rawSql": "SELECT CAST(m.measurements->'third_compile_generate_time_secs' AS double precision) AS third_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}';",
12101210
"refId": "A",
12111211
"sql": {
12121212
"columns": [
@@ -1314,7 +1314,7 @@
13141314
"editorMode": "code",
13151315
"format": "table",
13161316
"rawQuery": true,
1317-
"rawSql": "SELECT CAST(m.measurements->'fourth_compile_generate_time_secs' AS double precision) AS fourth_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = ${branch} AND gpu_name = '${gpu_name}';",
1317+
"rawSql": "SELECT CAST(m.measurements->'fourth_compile_generate_time_secs' AS double precision) AS fourth_compile_generate_time_secs, left(b.commit_id, 7), m.time FROM benchmarks as b JOIN model_measurements AS m ON b.benchmark_id = m.benchmark_id WHERE b.branch = '${branch}' AND gpu_name = '${gpu_name}';",
13181318
"refId": "A",
13191319
"sql": {
13201320
"columns": [
@@ -1442,7 +1442,7 @@
14421442
"editorMode": "code",
14431443
"format": "table",
14441444
"rawQuery": true,
1445-
"rawSql": "SELECT\n d.cpu_util,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = ${branch}",
1445+
"rawSql": "SELECT\n d.cpu_util,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = '${branch}'",
14461446
"refId": "A",
14471447
"sql": {
14481448
"columns": [
@@ -1627,7 +1627,7 @@
16271627
"editorMode": "code",
16281628
"format": "table",
16291629
"rawQuery": true,
1630-
"rawSql": "SELECT\n b.commit_id,\n d.gpu_util,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = ${branch}",
1630+
"rawSql": "SELECT\n b.commit_id,\n d.gpu_util,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = '${branch}'",
16311631
"refId": "A",
16321632
"sql": {
16331633
"columns": [
@@ -1812,7 +1812,7 @@
18121812
"editorMode": "code",
18131813
"format": "table",
18141814
"rawQuery": true,
1815-
"rawSql": "SELECT d.mem_megabytes, d.time FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = ${branch}",
1815+
"rawSql": "SELECT d.mem_megabytes, d.time FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = '${branch}'",
18161816
"refId": "A",
18171817
"sql": {
18181818
"columns": [
@@ -1997,7 +1997,7 @@
19971997
"editorMode": "code",
19981998
"format": "table",
19991999
"rawQuery": true,
2000-
"rawSql": "SELECT\n d.gpu_mem_megabytes,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = ${branch}",
2000+
"rawSql": "SELECT\n d.gpu_mem_megabytes,\n d.time\nFROM\n benchmarks AS b\n JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id\nWHERE\n branch = '${branch}'",
20012001
"refId": "A",
20022002
"sql": {
20032003
"columns": [
@@ -2099,13 +2099,9 @@
20992099
"list": [
21002100
{
21012101
"current": {
2102-
"selected": true,
2103-
"text": [
2104-
"refactor/benchmarks"
2105-
],
2106-
"value": [
2107-
"refactor/benchmarks"
2108-
]
2102+
"selected": false,
2103+
"text": "main",
2104+
"value": "main"
21092105
},
21102106
"datasource": {
21112107
"type": "grafana-postgresql-datasource",
@@ -2129,21 +2125,21 @@
21292125
{
21302126
"current": {
21312127
"selected": false,
2132-
"text": "1728570853117",
2133-
"value": "1728570853117"
2128+
"text": "1728662868776",
2129+
"value": "1728662868776"
21342130
},
21352131
"datasource": {
21362132
"type": "grafana-postgresql-datasource",
21372133
"uid": "de0dbhs18ho1sc"
21382134
},
2139-
"definition": "SELECT created_at - INTERVAL '5 secs' FROM benchmarks WHERE branch = ${branch} ORDER BY benchmark_id ASC LIMIT 1;",
2135+
"definition": "SELECT created_at - INTERVAL '5 secs' FROM benchmarks WHERE branch = '${branch}' ORDER BY benchmark_id ASC LIMIT 1;",
21402136
"description": "",
21412137
"hide": 2,
21422138
"includeAll": false,
21432139
"multi": false,
21442140
"name": "StartTime",
21452141
"options": [],
2146-
"query": "SELECT created_at - INTERVAL '5 secs' FROM benchmarks WHERE branch = ${branch} ORDER BY benchmark_id ASC LIMIT 1;",
2142+
"query": "SELECT created_at - INTERVAL '5 secs' FROM benchmarks WHERE branch = '${branch}' ORDER BY benchmark_id ASC LIMIT 1;",
21472143
"refresh": 2,
21482144
"regex": "",
21492145
"skipUrlSync": false,
@@ -2153,21 +2149,21 @@
21532149
{
21542150
"current": {
21552151
"selected": false,
2156-
"text": "1728657828802",
2157-
"value": "1728657828802"
2152+
"text": "1728663254125",
2153+
"value": "1728663254125"
21582154
},
21592155
"datasource": {
21602156
"type": "grafana-postgresql-datasource",
21612157
"uid": "de0dbhs18ho1sc"
21622158
},
2163-
"definition": "SELECT time + INTERVAL '5 secs' FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = ${branch} ORDER BY b.benchmark_id DESC, d.measurement_id DESC LIMIT 1;",
2159+
"definition": "SELECT time + INTERVAL '5 secs' FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = '${branch}' ORDER BY b.benchmark_id DESC, d.measurement_id DESC LIMIT 1;",
21642160
"description": "",
21652161
"hide": 2,
21662162
"includeAll": false,
21672163
"multi": false,
21682164
"name": "EndTime",
21692165
"options": [],
2170-
"query": "SELECT time + INTERVAL '5 secs' FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = ${branch} ORDER BY b.benchmark_id DESC, d.measurement_id DESC LIMIT 1;",
2166+
"query": "SELECT time + INTERVAL '5 secs' FROM benchmarks AS b JOIN device_measurements AS d ON b.benchmark_id = d.benchmark_id WHERE branch = '${branch}' ORDER BY b.benchmark_id DESC, d.measurement_id DESC LIMIT 1;",
21712167
"refresh": 2,
21722168
"regex": "",
21732169
"skipUrlSync": false,
@@ -2180,6 +2176,10 @@
21802176
"text": "NVIDIA A10G",
21812177
"value": "NVIDIA A10G"
21822178
},
2179+
"datasource": {
2180+
"type": "grafana-postgresql-datasource",
2181+
"uid": "de0dbhs18ho1sc"
2182+
},
21832183
"definition": "SELECT DISTINCT gpu_name FROM benchmarks;",
21842184
"hide": 0,
21852185
"includeAll": false,
@@ -2197,15 +2197,15 @@
21972197
]
21982198
},
21992199
"time": {
2200-
"from": "2024-10-11T13:10:01.641Z",
2201-
"to": "2024-10-11T13:25:21.783Z"
2200+
"from": "now-1h",
2201+
"to": "now"
22022202
},
22032203
"timepicker": {
22042204
"hidden": false
22052205
},
22062206
"timezone": "browser",
22072207
"title": "Transformers benchmarks",
22082208
"uid": "fdz33iyzln9c0a",
2209-
"version": 9,
2209+
"version": 11,
22102210
"weekStart": ""
22112211
}

0 commit comments

Comments
 (0)