📤 Fix a dataset loading bug in scripts

qgallouedec · qgallouedec · commit 05fd402af5b0 · 2025-09-23T14:54:33.000Z
diff --git a/trl/scripts/grpo.py b/trl/scripts/grpo.py
@@ -118,6 +118,7 @@ def main(script_args, training_args, model_args, dataset_args):
             "Both `datasets` and `dataset_name` are provided. The `datasets` argument will be used to load the "
             "dataset and `dataset_name` will be ignored."
         )
+        dataset = get_dataset(dataset_args)
     elif dataset_args.datasets and not script_args.dataset_name:
         dataset = get_dataset(dataset_args)
     elif not dataset_args.datasets and script_args.dataset_name:

Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,7 @@ def main(script_args, training_args, model_args, dataset_args):`
`118`	`118`	"Both `datasets` and `dataset_name` are provided. The `datasets` argument will be used to load the "
`119`	`119`	"dataset and `dataset_name` will be ignored."
`120`	`120`	`)`
	`121`	`+ dataset = get_dataset(dataset_args)`
`121`	`122`	`elif dataset_args.datasets and not script_args.dataset_name:`
`122`	`123`	`dataset = get_dataset(dataset_args)`
`123`	`124`	`elif not dataset_args.datasets and script_args.dataset_name:`