Skip to content

Commit aac19ee

Browse files
authored
Remove incorrect clippy allow (#550)
The attribute `#[allow(clippy::new_ret_no_self)]` is not appropriate for functions that return `Arc<Self>`.
1 parent cd64baa commit aac19ee

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

git_xet/src/auth/ssh.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ pub struct SSHCredentialHelper {
3636
}
3737

3838
impl SSHCredentialHelper {
39-
#[allow(clippy::new_ret_no_self)]
4039
pub fn new(remote_url: &GitUrl, operation: Operation) -> Arc<Self> {
4140
Arc::new(Self {
4241
remote_url: remote_url.clone(),

hub_client/src/auth/basics.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ use super::CredentialHelper;
99
pub struct NoopCredentialHelper {}
1010

1111
impl NoopCredentialHelper {
12-
#[allow(clippy::new_ret_no_self)]
1312
pub fn new() -> Arc<Self> {
1413
Arc::new(Self {})
1514
}
@@ -33,7 +32,6 @@ pub struct BearerCredentialHelper {
3332
}
3433

3534
impl BearerCredentialHelper {
36-
#[allow(clippy::new_ret_no_self)]
3735
pub fn new(hf_token: String, whoami: &'static str) -> Arc<Self> {
3836
Arc::new(Self {
3937
hf_token,

0 commit comments

Comments
 (0)