add type hints to hf_xet #418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoytak
approved these changes
Jul 22, 2025
Collaborator
hoytak
left a comment
hoytak
left a comment
There was a problem hiding this comment.
I'm assuming you're testing this in the IDE and they work...
Thanks for doing this! LGTM.
Contributor
Author
Yes, I tested with Pycharm, but I need to also probably verify this with VSCode. I'm holding off a bit on merging this to make sure that it doesn't interfere with huggingface_hub, I expect this will cause lints to fail on huggingface_hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a typing file to hf_xet, my particular interest to have this is the lack/limitation of IDE support when working with hf_xet functions from huggingface_hub library in pycharm/vscode.
Note: before releasing a client with this, we will need a huggingface_hub PR to make it adhere for
make qualityto pass since we've got some questionable type casts in hf_xet usage. Most flagrant is using anOptional[int]as anint