Merge pull request #85 from hugoh/golangci-baseline-lint-excludes

fix(golangci): drop lint excludes now covered by template baseline

Author: hugoh

.copier-answers.yml

@@ -1,5 +1,5 @@
 # Changes here will be overwritten by Copier; NEVER EDIT MANUALLY
-_commit: v1.16.9
+_commit: v1.19.0
 _src_path: https://github.com/hugoh/go-tools.git
 coverage_total: 100
 golangci_extra_disable: []
@@ -11,7 +11,6 @@ golangci_settings: ''
 golangci_test_exclude_linters:
 - depguard
 - goconst
-- varnamelen
 has_executable: true
 has_fuzz: true
 has_gen: false

.github/workflows/ci.yml

@@ -11,11 +11,11 @@ permissions: {}
 
 jobs:
   hk:
-    uses: hugoh/go-tools/.github/workflows/go-hk.yml@f9585764f4dcb3cb7bf8a81096573692db329e7e
+    uses: hugoh/go-tools/.github/workflows/go-hk.yml@37285d93779492692decb112f28f287551effedd
     permissions:
       contents: read
 
   goci:
-    uses: hugoh/go-tools/.github/workflows/go-ci.yml@f9585764f4dcb3cb7bf8a81096573692db329e7e
+    uses: hugoh/go-tools/.github/workflows/go-ci.yml@37285d93779492692decb112f28f287551effedd
     permissions:
       contents: read

.golangci.yml

@@ -2,14 +2,20 @@ version: "2"
 linters:
   default: all
   disable:
+    - depguard
+    - exhaustruct
+    - exhaustruct_v5
     - gomodguard
     - noinlineerr
     - paralleltest
+    - testpackage
     - wsl
   exclusions:
     rules:
       - path: _test\.go$
         linters:
+          - err113
+          - varnamelen
           - depguard
           - goconst
           - varnamelen

.renovaterc.json

@@ -1,18 +1,7 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "extends": ["github>hugoh/go-tools:go-renovaterc"],
-  "packageRules": [
-    {
-      "description": "hk.pkl is Copier-managed (regenerated on every `copier update` from go-tools' template). Let Copier own its version instead of Renovate bumping it directly, to avoid the two racing to update the same file.",
-      "matchManagers": ["custom.regex"],
-      "matchFileNames": ["hk.pkl"],
-      "enabled": false
-    },
-    {
-      "description": "mise.toml [tools] versions are Copier-managed too (regenerated on every `copier update` from go-tools' template's mise.toml.jinja). Let Copier own tool versions instead of Renovate bumping them directly, to avoid the two racing to update the same file. Covers both the built-in mise manager and hk-config's custom.regex manager (which bumps the `hk = \"...\"` line in mise.toml alongside hk.pkl).",
-      "matchManagers": ["mise", "custom.regex"],
-      "matchFileNames": ["mise.toml"],
-      "enabled": false
-    }
+  "extends": [
+    "github>hugoh/go-tools:go-renovaterc",
+    "github>hugoh/go-tools//presets/copier-owned-files"
   ]
 }

cog.toml

@@ -2,3 +2,6 @@ tag_prefix = "v"
 disable_changelog = true
 disable_bump_commit = true
 ignore_merge_commits = true
+
+[commit_types.perf]
+bump_patch = true

hk.pkl

@@ -1,6 +1,6 @@
-amends "package://github.com/jdx/hk/releases/download/v1.53.0/hk@1.53.0#/Config.pkl"
-import "package://github.com/jdx/hk/releases/download/v1.53.0/hk@1.53.0#/Builtins.pkl"
-import "package://github.com/hugoh/hk-config/releases/download/v1.2.4/hk-config@1.2.4#/base.pkl" as Base
+amends "package://github.com/jdx/hk/releases/download/v1.56.0/hk@1.56.0#/Config.pkl"
+import "package://github.com/jdx/hk/releases/download/v1.56.0/hk@1.56.0#/Builtins.pkl"
+import "package://github.com/hugoh/hk-config/releases/download/v1.4.1/hk-config@1.4.1#/base.pkl" as Base
 
 min_hk_version = Base.min_hk_version
 

mise-tasks/lint-release

@@ -1,4 +1,20 @@
 #!/usr/bin/env bash
 #MISE description="Check release config if present"
 #MISE sources=[".goreleaser.yml"]
-test ! -f .goreleaser.yml || goreleaser check
+set -uo pipefail
+
+[ -f .goreleaser.yml ] || exit 0
+
+out=$(goreleaser check 2>&1)
+ec=$?
+printf '%s\n' "$out"
+[ "$ec" -eq 0 ] && exit 0
+
+# goreleaser check fails even on configs it calls "valid" if they use a
+# deprecated property (e.g. brews instead of homebrew_casks). Deprecation
+# is a lint concern, not a validity one, so don't hard-fail CI on it.
+if [ "$ec" -eq 2 ] && printf '%s\n' "$out" | grep -q 'configuration is valid, but uses deprecated properties'; then
+  exit 0
+fi
+
+exit "$ec"

mise.toml

@@ -1,10 +1,12 @@
 [tools]
-go = "1.26.5"
-"go:github.com/vladopajic/go-test-coverage/v2" = "2.18.8"
-golangci-lint = "2.12.2"
+go = "1.27.0"
+golangci-lint = "2.13.1"
+gotestsum = "1.13.0"
+"go:github.com/vladopajic/go-test-coverage/v2" = "2.19.0"
+"go:golang.org/x/tools/cmd/deadcode" = "0.49.0"
+"go:golang.org/x/vuln/cmd/govulncheck" = "1.7.0"
 #
 cocogitto = "7.0.0"
-gotestsum = "1.13.0"
 hk = "1.52.0"
 rumdl = "0.2.34"
 zizmor = "1.27.0"
@@ -21,8 +23,6 @@ shfmt = "3.13.1"
 tombi = "1.2.0"
 "github:owenlamont/ryl" = "0.21.0"
 "npm:cpd" = "5.0.10"
-"go:golang.org/x/tools/cmd/deadcode" = "0.48.0"
-"go:golang.org/x/vuln/cmd/govulncheck" = "1.6.0"
 
 [env]
 COVEROUT = "cover.out"