Refactor argparse into main()

Author: hugovk

needs_backport.py

@@ -38,7 +38,7 @@
 
 
 @cache
-def get_pr_commit(pull_number: int) -> str:
+def get_pr_commit(api: GhApi, pull_number: int) -> str:
     return api.pulls.get(pull_number=pull_number).merge_commit_sha
 
 
@@ -63,6 +63,7 @@ def is_commit_title_in_branch(repo_path: str, title: str, branch: str) -> bool:
 
 
 def check_prs(
+    api: GhApi,
     repo_path: str,
     branch_to_check: str,
     start: int = 1,
@@ -100,7 +101,7 @@ def check_prs(
             if not pr.pull_request.merged_at:
                 # PR was closed without being merged, skip it
                 continue
-            commit = get_pr_commit(pr.number)
+            commit = get_pr_commit(api, pr.number)
             title = get_title_of_commit(repo_path, commit)
             print(f"  {title}")
 
@@ -114,13 +115,50 @@ def check_prs(
     return candidates
 
 
-def main(args) -> None:
+def main() -> None:
+    parser = argparse.ArgumentParser(
+        description=__doc__,
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter,
+    )
+    parser.add_argument("repo_path", help="path to CPython repo")
+    parser.add_argument(
+        "-b",
+        "--branches",
+        default="3.13,3.12,3.11,3.10,3.9",
+        help="branches to check",
+    )
+    parser.add_argument(
+        "-s", "--start", default=1, type=int, help="start at this PR number"
+    )
+    parser.add_argument(
+        "-n", "--number", default=100, type=int, help="number of PRs to check"
+    )
+    parser.add_argument(
+        "--sort",
+        default="newest",
+        choices=(
+            "newest",
+            "oldest",
+            "most-commented",
+            "least-commented",
+            "recently-updated",
+            "least-recently-updated",
+        ),
+        help="Sort by",
+    )
+    parser.add_argument(
+        "-o", "--open-prs", action="store_true", help="open PRs in browser"
+    )
+    args = parser.parse_args()
+
+    api = GhApi(owner="python", repo="cpython", token=GITHUB_TOKEN)
+
     # Find
     total_candidates = defaultdict(list)
     for branch in args.branches.split(","):
         print(f"\nChecking branch {branch}")
         candidates = check_prs(
-            args.repo_path, branch, args.start, args.number, args.sort
+            api, args.repo_path, branch, args.start, args.number, args.sort
         )
         for reason, prs in candidates.items():
             total_candidates[reason].extend(prs)
@@ -154,40 +192,4 @@ def report(prs: list[PR]):
 
 
 if __name__ == "__main__":
-    parser = argparse.ArgumentParser(
-        description=__doc__,
-        formatter_class=argparse.ArgumentDefaultsHelpFormatter,
-    )
-    parser.add_argument("repo_path", help="path to CPython repo")
-    parser.add_argument(
-        "-b",
-        "--branches",
-        default="3.13,3.12,3.11,3.10,3.9",
-        help="branches to check",
-    )
-    parser.add_argument(
-        "-s", "--start", default=1, type=int, help="start at this PR number"
-    )
-    parser.add_argument(
-        "-n", "--number", default=100, type=int, help="number of PRs to check"
-    )
-    parser.add_argument(
-        "--sort",
-        default="newest",
-        choices=(
-            "newest",
-            "oldest",
-            "most-commented",
-            "least-commented",
-            "recently-updated",
-            "least-recently-updated",
-        ),
-        help="Sort by",
-    )
-    parser.add_argument(
-        "-o", "--open-prs", action="store_true", help="open PRs in browser"
-    )
-    args = parser.parse_args()
-
-    api = GhApi(owner="python", repo="cpython", token=GITHUB_TOKEN)
-    main(args)
+    main()