Skip to content

Commit 81e6ffa

Browse files
authored
Merge pull request #117 from AdjectiveAllison/allison/eng-1319-change-request-url-to-token-and-baseurl
using channelToken and baseURL instead of responseURL
2 parents 85a4694 + 5248628 commit 81e6ffa

File tree

10 files changed

+385
-496
lines changed

10 files changed

+385
-496
lines changed

acp/api/v1alpha1/task_types.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,13 @@ type TaskSpec struct {
3838
// +optional
3939
ContextWindow []Message `json:"contextWindow,omitempty"`
4040

41-
// ResponseURL specifies a pre-generated URL that will be used for human contact responses.
42-
// This allows the system to direct responses to a specific endpoint.
41+
// BaseURL specifies the base URL for the human contact channel.
4342
// +optional
44-
ResponseURL string `json:"responseURL,omitempty"`
43+
BaseURL string `json:"baseURL,omitempty"`
44+
45+
// ChannelTokenFrom references a secret containing the token for the human contact channel.
46+
// +optional
47+
ChannelTokenFrom *SecretKeyRef `json:"channelTokenFrom,omitempty"`
4548
}
4649

4750
// Message represents a single message in the conversation

acp/api/v1alpha1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

acp/config/crd/bases/acp.humanlayer.dev_tasks.yaml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,24 @@ spec:
8585
required:
8686
- name
8787
type: object
88+
baseURL:
89+
description: BaseURL specifies the base URL for the human contact
90+
channel.
91+
type: string
92+
channelTokenFrom:
93+
description: ChannelTokenFrom references a secret containing the token
94+
for the human contact channel.
95+
properties:
96+
key:
97+
description: Key is the key in the secret
98+
type: string
99+
name:
100+
description: Name is the name of the secret
101+
type: string
102+
required:
103+
- key
104+
- name
105+
type: object
88106
contextWindow:
89107
description: |-
90108
ContextWindow provides the initial conversation context when creating a Task.
@@ -153,11 +171,6 @@ spec:
153171
- role
154172
type: object
155173
type: array
156-
responseURL:
157-
description: |-
158-
ResponseURL specifies a pre-generated URL that will be used for human contact responses.
159-
This allows the system to direct responses to a specific endpoint.
160-
type: string
161174
userMessage:
162175
description: |-
163176
UserMessage is the message to send to the agent.

acp/config/localdev/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ patches:
2626
images:
2727
- name: controller
2828
newName: controller
29-
newTag: "202505141822"
29+
newTag: "202505211432"
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
apiVersion: acp.humanlayer.dev/v1alpha1
1+
apiVersion: acp.humanlayer.dev/v1alpha1
22
kind: Task
33
metadata:
44
name: fetch-example
55
spec:
66
agentRef:
77
name: web-fetch-agent
88
userMessage: "Please fetch the content from example.com and summarize what's on the site."
9+
baseURL: "https://api.humanlayer.dev"
10+
channelTokenFrom:
11+
name: channel-token-secret
12+
key: token

acp/internal/controller/task/send_response_url_test.go

Lines changed: 0 additions & 146 deletions
This file was deleted.

0 commit comments

Comments
 (0)