Skip to content

lesss go#111

Merged
allisoneer merged 2 commits intohumanlayer:mainfrom
allisoneer:ci_claude
May 20, 2025
Merged

lesss go#111
allisoneer merged 2 commits intohumanlayer:mainfrom
allisoneer:ci_claude

Conversation

@allisoneer
Copy link
Contributor

@allisoneer allisoneer commented May 20, 2025

Important

Replace GitHub CLI with API calls and git commands for PR branch checkout in claude-comment-response.yml.

  • Workflow Changes:
    • In .github/workflows/claude-comment-response.yml, replace GitHub CLI gh pr checkout with API calls and git commands to fetch and checkout PR branches.
    • Use curl to get PR info and jq to parse JSON for branch details.
    • Fetch PR as a local branch using git fetch and git checkout.
  • Environment Variables:
    • Rename GH_TOKEN to GITHUB_TOKEN for consistency.

This description was created by Ellipsis for c0ce461. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to c0ce461 in 1 minute and 42 seconds. Click for details.
  • Reviewed 42 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/claude-comment-response.yml:28
  • Draft comment:
    Rename env var to GITHUB_TOKEN for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/claude-comment-response.yml:39
  • Draft comment:
    Validate PR info before using jq to avoid null parsing.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. .github/workflows/claude-comment-response.yml:47
  • Draft comment:
    Check the success of the git fetch command and handle errors.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. .github/workflows/claude-comment-response.yml:41
  • Draft comment:
    PR_SHA is extracted but not used; consider removing if unnecessary.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. .github/workflows/claude-comment-response.yml:48
  • Draft comment:
    Manual checkout via fetch may miss fork-specific edge cases; confirm its reliability.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_KrNilqHpNljxQYnH

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@allisoneer
Copy link
Contributor Author

merging for iterative CI development

@allisoneer allisoneer merged commit 08e2d1e into humanlayer:main May 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments