Merge pull request #2 from humanpred/testing

billdenney · web-flow · commit 30246d34df9a · 2025-02-25T16:06:37.000-05:00
Improve testing
diff --git a/NAMESPACE b/NAMESPACE
@@ -4,6 +4,7 @@ S3method(format,tab_list)
 S3method(knit_print,tab_list)
 S3method(knit_print,tab_tibble)
 S3method(print,tab_list)
+S3method(vctrs::vec_ptype_abbr,tab_list)
 export(knit_print)
 export(new_tab_list)
 export(new_tab_tibble)
diff --git a/R/objects.R b/R/objects.R
@@ -27,8 +27,9 @@ new_tab_list <- function(x) {
   vctrs::new_vctr(x, class = "tab_list")
 }
 
+#' @exportS3Method vctrs::vec_ptype_abbr
 vec_ptype_abbr.tab_list <- function(x, ...) {
-  "tablist"
+  "tab_list"
 }
 
 #' @export
diff --git a/tests/testthat/test-knit_print.R b/tests/testthat/test-knit_print.R
@@ -7,7 +7,7 @@ test_that("knit_print.tab_tibble (and implicitly knit_print.tab_list and print_t
     ) |>
     new_tab_tibble()
   expect_output(
-    knit_print(d_tab),
+    suppressWarnings(knit_print(d_tab)),
     regexp = "Cars with 8 cylinders"
   )
   expect_output(

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,9 @@ new_tab_list <- function(x) {`
`27`	`27`	`vctrs::new_vctr(x, class = "tab_list")`
`28`	`28`	`}`
`29`	`29`
	`30`	`+#' @exportS3Method vctrs::vec_ptype_abbr`
`30`	`31`	`vec_ptype_abbr.tab_list <- function(x, ...) {`
`31`		`- "tablist"`
	`32`	`+ "tab_list"`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`#' @export`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ test_that("knit_print.tab_tibble (and implicitly knit_print.tab_list and print_t`
`7`	`7`	`) \|>`
`8`	`8`	`new_tab_tibble()`
`9`	`9`	`expect_output(`
`10`		`- knit_print(d_tab),`
	`10`	`+ suppressWarnings(knit_print(d_tab)),`
`11`	`11`	`regexp = "Cars with 8 cylinders"`
`12`	`12`	`)`
`13`	`13`	`expect_output(`