Improve testing

Author: billdenney

R/objects.R

@@ -22,7 +22,7 @@ new_tab_list <- function(x) {
   x_null <- vapply(X = x, FUN = is.null, FUN.VALUE = TRUE)
   x_df <- vapply(X = x, FUN = inherits, "data.frame", FUN.VALUE = TRUE)
   if (!all(x_null | x_df)) {
-    stop("the contents of 'x' must be NULL or a 'data.frame'-like object")
+    stop("The contents of 'x' must be NULL or a 'data.frame'-like object")
   }
   vctrs::new_vctr(x, class = "tab_list")
 }

tests/testthat/test-knit_print.R

@@ -10,4 +10,8 @@ test_that("knit_print.tab_tibble (and implicitly knit_print.tab_list and print_t
     knit_print(d_tab),
     regexp = "Cars with 8 cylinders"
   )
+  expect_output(
+    suppressWarnings(knit_print(d_tab, tab_prefix = "foo")),
+    regexp = "foo"
+  )
 })

tests/testthat/test-objects.R

@@ -8,6 +8,15 @@ test_that("new_tab_tibble", {
 test_that("new_tab_list", {
   new_tl <- new_tab_list(list(data.frame(a = 1)))
   expect_s3_class(new_tl, "tab_list")
+
+  expect_error(
+    new_tab_list("A"),
+    regexp = "`x` must be a list"
+  )
+  expect_error(
+    new_tab_list(list("A")),
+    regexp = "The contents of 'x' must be NULL or a 'data.frame'-like object"
+  )
 })
 
 test_that("vctrs methods", {
@@ -22,4 +31,9 @@ test_that("vctrs methods", {
     print(d_tab),
     regexp = "Cars with 8 cylinders"
   )
+  expect_output(
+    print(d_tab$table),
+    "mpg"
+  )
+  expect_equal(vctrs::vec_ptype_abbr(d_tab$table), "tab_list")
 })