Now detect invalid padding

Nicholas C. Zakas · Nicholas C. Zakas · commit bcd60047639b · 2009-11-28T10:32:12.000-08:00
diff --git a/encodings/base64/base64.js b/encodings/base64/base64.js
@@ -83,7 +83,7 @@ function base64Decode(text){
     text = text.replace(/\s/g,"");
         
     //first check for any unexpected input
-    if(!(/^[a-z0-9\+\/\s]+\={0,2}$/i.test(text)) | text.length % 4 > 0){
+    if(!(/^[a-z0-9\+\/\s]+\={0,2}$/i.test(text)) || text.length % 4 > 0){
         throw new Error("Not a base64-encoded string.");
     }    
 

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ function base64Decode(text){`
`83`	`83`	`text = text.replace(/\s/g,"");`
`84`	`84`
`85`	`85`	`//first check for any unexpected input`
`86`		`- if(!(/^[a-z0-9\+\/\s]+\={0,2}$/i.test(text)) \| text.length % 4 > 0){`
	`86`	`+ if(!(/^[a-z0-9\+\/\s]+\={0,2}$/i.test(text)) \|\| text.length % 4 > 0){`
`87`	`87`	`throw new Error("Not a base64-encoded string.");`
`88`	`88`	`}`
`89`	`89`