Apply CodeSniffer (#273)

Author: theofidry

.gitignore

@@ -12,6 +12,5 @@
 /vendor/
 /vendor-bin/*/vendor/
 /vendor-bin/*/bin/
-/.travis/
-!/.travis/.gitkeep
-!/.travis/secrets.tar.enc
+/.phpcs-cache
+/phpcs.xml

.travis/.gitkeep

@@ -23,7 +23,7 @@ CODE_SNIFFER_FIX=vendor-bin/code-sniffer/vendor/bin/phpcbf
 cs:	## Fixes CS
 cs: $(CODE_SNIFFER) $(CODE_SNIFFER_FIX)
 	$(PHPNOGC) $(CODE_SNIFFER_FIX) || true
-	$(PHPNOGC) $(PHP_CS_FIXER) fix
+	$(PHPNOGC) $(CODE_SNIFFER)
 
 .PHONY: build
 build:	## Build the PHAR

.travis/secrets.tar.enc

@@ -10,10 +10,6 @@
     <arg name="colors"/>
     <arg value="ps"/>
 
-    <file>fixtures</file>
-    <exclude-pattern>default_stub\.php</exclude-pattern>
-    <exclude-pattern>/vendor/</exclude-pattern>
-    <exclude-pattern>/build/</exclude-pattern>
     <file>src</file>
     <file>tests</file>
 

Makefile

@@ -100,7 +100,7 @@ public function dump(string $prefix): string
     private function createClassAliasStatements(array $whitelistedClasses, bool $hasNamespacedFunctions): array
     {
         $statements = array_map(
-            function (string $prefixedClass): string {
+            static function (string $prefixedClass): string {
                 return sprintf(
                     'class_exists(\'%s\');',
                     $prefixedClass
@@ -118,7 +118,7 @@ function (string $prefixedClass): string {
 
         if ($hasNamespacedFunctions) {
             $statements = array_map(
-                function (string $statement): string {
+                static function (string $statement): string {
                     return str_repeat(' ', 4).$statement;
                 },
                 $statements
@@ -145,7 +145,7 @@ function (string $statement): string {
     private function createFunctionAliasStatements(array $whitelistedFunctions, bool $hasNamespacedFunctions): array
     {
         $statements = array_map(
-            function (array $node) use ($hasNamespacedFunctions): string {
+            static function (array $node) use ($hasNamespacedFunctions): string {
                 /**
                  * @var string
                  * @var string $alias

phpcs.xml.dist

@@ -499,7 +499,7 @@ private static function retrieveFilesFromPaths(array $paths): iterable
         $finder->files()
             ->in($pathsToSearch)
             ->append($filesToAppend)
-            ->filter(function (SplFileInfo $fileInfo): ?bool {
+            ->filter(static function (SplFileInfo $fileInfo): ?bool {
                 if ($fileInfo->isLink()) {
                     return false;
                 }
@@ -521,7 +521,7 @@ private static function retrieveFilesWithContents(Iterator $files): array
     {
         return array_reduce(
             iterator_to_array($files),
-            function (array $files, SplFileInfo $fileInfo): array {
+            static function (array $files, SplFileInfo $fileInfo): array {
                 $file = $fileInfo->getRealPath();
 
                 if (false === $file) {

src/Autoload/ScoperAutoloadGenerator.php

@@ -215,7 +215,7 @@ private function scopeFiles(
 
         usort(
             $vendorDirs,
-            function ($a, $b) {
+            static function ($a, $b) {
                 return strlen($b) <=> strlen($a);
             }
         );
@@ -287,7 +287,7 @@ private function validatePaths(InputInterface $input): void
         $fileSystem = $this->fileSystem;
 
         $paths = array_map(
-            function (string $path) use ($cwd, $fileSystem) {
+            static function (string $path) use ($cwd, $fileSystem) {
                 if (false === $fileSystem->isAbsolutePath($path)) {
                     return $cwd.DIRECTORY_SEPARATOR.$path;
                 }

src/Configuration.php

@@ -149,7 +149,7 @@ private function replaceGroupUseStatements(array $nodes): array
     private function createUses_(GroupUse $node): array
     {
         return array_map(
-            function (UseUse $use) use ($node): Use_ {
+            static function (UseUse $use) use ($node): Use_ {
                 $newUse = new UseUse(
                     Name::concat($node->prefix, $use->name, $use->name->getAttributes()),
                     $use->alias,

src/Console/Command/AddPrefixCommand.php

@@ -46,7 +46,7 @@ final class NamespaceStmtCollection implements IteratorAggregate, Countable
      * @param Namespace_ $node         New namespace, may have been prefixed.
      * @param Namespace_ $originalName Original unchanged namespace.
      */
-    public function add(Namespace_ $node, Namespace_ $originalName)
+    public function add(Namespace_ $node, Namespace_ $originalName): void
     {
         $this->nodes[] = $originalName;